📦 Revert check for static call as unneeded here

andrew-demb · andrew-demb · commit 1b83816ab095 · 2025-05-02T16:07:01.000+02:00
As of review comment #482 (comment)
diff --git a/rules/CodeQuality/NodeAnalyser/AssertMethodAnalyzer.php b/rules/CodeQuality/NodeAnalyser/AssertMethodAnalyzer.php
@@ -35,11 +35,11 @@ public function detectTestCaseCall(MethodCall|StaticCall $call): bool
         }
 
         $methodName = $this->nodeNameResolver->getName($call->name);
-        if (! str_starts_with((string) $methodName, 'assert') && ! ($call instanceof StaticCall && in_array(
+        if (! str_starts_with((string) $methodName, 'assert') && ! in_array(
             $methodName,
             NonAssertNonStaticMethods::ALL,
             true
-        ))) {
+        )) {
             return false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -35,11 +35,11 @@ public function detectTestCaseCall(MethodCall\|StaticCall $call): bool`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`$methodName = $this->nodeNameResolver->getName($call->name);`
`38`		`- if (! str_starts_with((string) $methodName, 'assert') && ! ($call instanceof StaticCall && in_array(`
	`38`	`+ if (! str_starts_with((string) $methodName, 'assert') && ! in_array(`
`39`	`39`	`$methodName,`
`40`	`40`	`NonAssertNonStaticMethods::ALL,`
`41`	`41`	`true`
`42`		`- ))) {`
	`42`	`+ )) {`
`43`	`43`	`return false;`
`44`	`44`	`}`
`45`	`45`