[rector] Rector fixes

Author: actions-user

config/sets/phpunit120.php

@@ -4,7 +4,6 @@
 
 use Rector\Config\RectorConfig;
 use Rector\PHPUnit\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector;
-use Rector\PHPUnit\PHPUnit120\Rector\Class_\AllowMockObjectsWithoutExpectationsAttributeRector;
 use Rector\PHPUnit\PHPUnit120\Rector\Class_\AssertIsTypeMethodCallRector;
 use Rector\PHPUnit\PHPUnit120\Rector\Class_\RemoveOverrideFinalConstructTestCaseRector;
 

rules/PHPUnit120/Rector/Class_/AllowMockObjectsWithoutExpectationsAttributeRector.php

@@ -4,6 +4,8 @@
 
 namespace Rector\PHPUnit\PHPUnit120\Rector\Class_;
 
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node;
 use PhpParser\Node\Attribute;
 use PhpParser\Node\AttributeGroup;
@@ -14,7 +16,6 @@
 use PHPStan\Reflection\ReflectionProvider;
 use Rector\Doctrine\NodeAnalyzer\AttributeFinder;
 use Rector\PhpParser\Node\BetterNodeFinder;
-use Rector\PhpParser\NodeFinder\PropertyFetchFinder;
 use Rector\PHPUnit\Enum\PHPUnitAttribute;
 use Rector\PHPUnit\Enum\PHPUnitClassName;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
@@ -204,10 +205,10 @@ private function shouldSkipClass(Class_ $class): bool
 
     private function isClassMethodUsingMethodCallOnPropertyNamed(ClassMethod $classMethod, string $mockObjectPropertyName): bool
     {
-        /** @var Node\Expr\MethodCall[] $methodCalls */
-        $methodCalls = $this->betterNodeFinder->findInstancesOfScoped([$classMethod], [Node\Expr\MethodCall::class]);
+        /** @var MethodCall[] $methodCalls */
+        $methodCalls = $this->betterNodeFinder->findInstancesOfScoped([$classMethod], [MethodCall::class]);
         foreach ($methodCalls as $methodCall) {
-            if (!$methodCall->var instanceof Node\Expr\PropertyFetch) {
+            if (!$methodCall->var instanceof PropertyFetch) {
                 continue;
             }
 
@@ -224,7 +225,7 @@ private function isClassMethodUsingMethodCallOnPropertyNamed(ClassMethod $classM
 
     private function shouldAddAttribute(array $missedTestMethodsByMockPropertyName): bool
     {
-        foreach ($missedTestMethodsByMockPropertyName as $propertyName => $missedTestMethods) {
+        foreach ($missedTestMethodsByMockPropertyName as $missedTestMethods) {
             // all test methods are using method calls on the mock property, so skip
             if (count($missedTestMethods) === 0) {
                 continue;