Fix RemoveNamedArgsInDataProviderRector so that it is not applied if no change is made

Author: carlos-granados

rules-tests/PHPUnit100/Rector/Class_/RemoveNamedArgsInDataProviderRector/Fixture/provide_data_with_no_named_args.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit100\Rector\Class_\RemoveNamedArgsInDataProviderRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class ProvideDataWithNoNamedArgs extends TestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test()
+    {
+    }
+
+    public static function provideData()
+    {
+        yield [100];
+    }
+}
+
+?>

rules-tests/PHPUnit100/Rector/Class_/RemoveNamedArgsInDataProviderRector/Fixture/skip_provide_data_with_no_named_args.php.inc

@@ -99,11 +99,13 @@ public function refactor(Node $node): ?Node
             /** @var Expression $stmt */
             foreach ($dataProvider->getStmts() ?? [] as $stmt) {
                 $expr = $stmt->expr;
+                $arrayChanged = false;
                 if ($expr instanceof Yield_) {
-                    $this->handleStmt($expr->value);
-                    $hasChanged = true;
+                    $arrayChanged = $this->handleArray($expr->value);
                 } elseif ($expr instanceof Array_) {
-                    $this->handleStmt($expr);
+                    $arrayChanged = $this->handleArray($expr);
+                }
+                if ($arrayChanged) {
                     $hasChanged = true;
                 }
             }
@@ -116,16 +118,19 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
-    private function handleStmt(Array_ $array): void
+    private function handleArray(Array_ $array): bool
     {
+        $hasChanged = false;
         foreach ($array->items as $item) {
             if (! $item instanceof ArrayItem) {
                 continue;
             }
 
-            if (! $item->key instanceof Int_) {
+            if (! $item->key instanceof Int_ && $item->key !== null) {
                 $item->key = null;
+                $hasChanged = true;
             }
         }
+        return $hasChanged;
     }
 }