[fix] Improve AssertComparisonToSpecificMethodRector for assert false

Author: TomasVotruba

rules-tests/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector/Fixture/assert_false_greater.php.inc

@@ -4,12 +4,13 @@ namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToS
 
 use PHPUnit\Framework\TestCase;
 
-final class AssertTrueToLessThan extends TestCase
+final class AssertFalseGreater extends TestCase
 {
     public function some(int $param)
     {
-        self::assertTrue(0 < $param);
-        self::assertTrue(0 <= $param);
+        self::assertFalse(0 > $param);
+
+        self::assertFalse(10 >= $param);
     }
 }
 
@@ -21,12 +22,13 @@ namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToS
 
 use PHPUnit\Framework\TestCase;
 
-final class AssertTrueToLessThan extends TestCase
+final class AssertFalseGreater extends TestCase
 {
     public function some(int $param)
     {
-        self::assertLessThan($param, 0);
         self::assertLessThanOrEqual($param, 0);
+
+        self::assertLessThanOrEqual($param, 10);
     }
 }
 

rules-tests/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector/Fixture/assert_false_smaller.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AssertFalseSmaller extends TestCase
+{
+    public function some(int $param)
+    {
+        self::assertFalse(0 < $param);
+
+        self::assertFalse(10 <= $param);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AssertFalseSmaller extends TestCase
+{
+    public function some(int $param)
+    {
+        self::assertGreaterThanOrEqual($param, 0);
+
+        self::assertGreaterThan($param, 10);
+    }
+}
+
+?>

rules/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector.php

@@ -46,18 +46,16 @@ public function __construct(
             new BinaryOpWithAssertMethod(NotIdentical::class, 'assertNotSame', 'assertSame'),
             new BinaryOpWithAssertMethod(Equal::class, 'assertEquals', 'assertNotEquals'),
             new BinaryOpWithAssertMethod(NotEqual::class, 'assertNotEquals', 'assertEquals'),
-            new BinaryOpWithAssertMethod(Greater::class, 'assertGreaterThan', 'assertLessThan'),
-            new BinaryOpWithAssertMethod(Smaller::class, 'assertLessThan', 'assertGreaterThan'),
+
+            new BinaryOpWithAssertMethod(Greater::class, 'assertGreaterThan', 'assertLessThanOrEqual'),
+            new BinaryOpWithAssertMethod(Smaller::class, 'assertLessThan', 'assertGreaterThanOrEqual'),
             new BinaryOpWithAssertMethod(
                 GreaterOrEqual::class,
                 'assertGreaterThanOrEqual',
                 'assertLessThanOrEqual'
             ),
-            new BinaryOpWithAssertMethod(
-                SmallerOrEqual::class,
-                'assertLessThanOrEqual',
-                'assertGreaterThanOrEqual'
-            ),
+
+            new BinaryOpWithAssertMethod(SmallerOrEqual::class, 'assertLessThanOrEqual', 'assertGreaterThan'),
         ];
     }