🐛 [9138] Ensure that rule PreferPHPUnitSelfCall refactor call only for static methods, not any

rectorphp/rector#9138

Author: andrew-demb

rules-tests/CodeQuality/Rector/Class_/PreferPHPUnitSelfCallRector/Fixture/include_exceptions.php.inc

@@ -26,9 +26,9 @@ final class IncludeExceptions extends TestCase
 {
     public function testMe()
     {
-        self::expectException(\RuntimeException::class);
-        self::expectExceptionMessage('foo');
-        self::expectExceptionCode(123);
+        $this->expectException(\RuntimeException::class);
+        $this->expectExceptionMessage('foo');
+        $this->expectExceptionCode(123);
     }
 }
 

…lity/Enum/NonAssertStaticableMethods.php …um/NonAssertPrefixedAssertionMethods.phprules/CodeQuality/Enum/NonAssertStaticableMethods.php renamed to rules/CodeQuality/Enum/NonAssertPrefixedAssertionMethods.php rules/CodeQuality/Enum/NonAssertStaticableMethods.php renamed to rules/CodeQuality/Enum/NonAssertPrefixedAssertionMethods.php

@@ -4,7 +4,7 @@
 
 namespace Rector\PHPUnit\CodeQuality\Enum;
 
-final class NonAssertStaticableMethods
+final class NonAssertPrefixedAssertionMethods
 {
     /**
      * @var string[]

rules/CodeQuality/NodeAnalyser/AssertMethodAnalyzer.php

@@ -7,10 +7,11 @@
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
 use PHPStan\Reflection\ClassReflection;
+use PHPStan\Reflection\ExtendedMethodReflection;
 use PHPStan\Type\ObjectType;
 use Rector\NodeNameResolver\NodeNameResolver;
 use Rector\NodeTypeResolver\NodeTypeResolver;
-use Rector\PHPUnit\CodeQuality\Enum\NonAssertStaticableMethods;
+use Rector\PHPUnit\CodeQuality\Enum\NonAssertPrefixedAssertionMethods;
 use Rector\PHPUnit\Enum\PHPUnitClassName;
 use Rector\Reflection\ReflectionResolver;
 
@@ -36,7 +37,7 @@ public function detectTestCaseCall(MethodCall|StaticCall $call): bool
         $methodName = $this->nodeNameResolver->getName($call->name);
         if (! str_starts_with((string) $methodName, 'assert') && ! in_array(
             $methodName,
-            NonAssertStaticableMethods::ALL
+            NonAssertPrefixedAssertionMethods::ALL
         )) {
             return false;
         }
@@ -45,17 +46,38 @@ public function detectTestCaseCall(MethodCall|StaticCall $call): bool
             return false;
         }
 
-        $classReflection = $this->reflectionResolver->resolveClassReflection($call);
-        if (! $classReflection instanceof ClassReflection) {
+        $extendedMethodReflection = $this->resolveMethodReflection($call);
+        if (! $extendedMethodReflection instanceof ExtendedMethodReflection) {
             return false;
         }
 
-        $extendedMethodReflection = $classReflection->getNativeMethod($methodName);
-
         // only handle methods in TestCase or Assert class classes
         $declaringClassName = $extendedMethodReflection->getDeclaringClass()
             ->getName();
 
         return in_array($declaringClassName, [PHPUnitClassName::TEST_CASE, PHPUnitClassName::ASSERT]);
     }
+
+    public function detectTestCaseCallForStatic(MethodCall $methodCall): bool
+    {
+        if (! $this->detectTestCaseCall($methodCall)) {
+            return false;
+        }
+
+        $extendedMethodReflection = $this->resolveMethodReflection($methodCall);
+
+        return $extendedMethodReflection instanceof ExtendedMethodReflection && $extendedMethodReflection->isStatic();
+    }
+
+    private function resolveMethodReflection(MethodCall|StaticCall $call): ?ExtendedMethodReflection
+    {
+        $methodName = $this->nodeNameResolver->getName($call->name);
+
+        $classReflection = $this->reflectionResolver->resolveClassReflection($call);
+        if (! $classReflection instanceof ClassReflection) {
+            return null;
+        }
+
+        return $classReflection->getNativeMethod($methodName);
+    }
 }

rules/CodeQuality/Rector/Class_/PreferPHPUnitSelfCallRector.php

@@ -83,7 +83,7 @@ public function refactor(Node $node): ?Node
                 return null;
             }
 
-            if (! $this->assertMethodAnalyzer->detectTestCaseCall($node)) {
+            if (! $this->assertMethodAnalyzer->detectTestCaseCallForStatic($node)) {
                 return null;
             }