add array item support to CreateStubOverCreateMockArgRector

Author: TomasVotruba

rules-tests/CodeQuality/Rector/CallLike/DirectInstanceOverMockArgRector/Fixture/handle_static_call.php

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class HandleArrayItem extends TestCase
+{
+    public function testThat()
+    {
+        $items = [
+            $this->createMock(\stdClass::class),
+        ];
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class HandleArrayItem extends TestCase
+{
+    public function testThat()
+    {
+        $items = [
+            $this->createStub(\stdClass::class),
+        ];
+    }
+}
+
+?>

rules-tests/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector/Fixture/handle_array_item.php.inc

@@ -5,6 +5,7 @@
 namespace Rector\PHPUnit\PHPUnit120\Rector\CallLike;
 
 use PhpParser\Node;
+use PhpParser\Node\ArrayItem;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\New_;
 use PhpParser\Node\Expr\StaticCall;
@@ -25,7 +26,7 @@ final class CreateStubOverCreateMockArgRector extends AbstractRector
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
-            'Use createStub() over createMock() when used as argument and does not add any mock requirements',
+            'Use createStub() over createMock() when used as argument or array value and does not add any mock requirements',
             [
                 new CodeSample(
                     <<<'CODE_SAMPLE'
@@ -69,13 +70,13 @@ private function someMethod($someClass)
      */
     public function getNodeTypes(): array
     {
-        return [StaticCall::class, MethodCall::class, New_::class];
+        return [StaticCall::class, MethodCall::class, New_::class, ArrayItem::class];
     }
 
     /**
-     * @param MethodCall|StaticCall|New_ $node
+     * @param MethodCall|StaticCall|New_|ArrayItem $node
      */
-    public function refactor(Node $node): MethodCall|StaticCall|New_|null
+    public function refactor(Node $node): MethodCall|StaticCall|New_|ArrayItem|null
     {
         $scope = ScopeFetcher::fetch($node);
         if (! $scope->isInClass()) {
@@ -87,6 +88,21 @@ public function refactor(Node $node): MethodCall|StaticCall|New_|null
             return null;
         }
 
+        if ($node instanceof ArrayItem) {
+            if (! $node->value instanceof MethodCall) {
+                return null;
+            }
+
+            $methodCall = $node->value;
+            if (! $this->isName($methodCall->name, 'createMock')) {
+                return null;
+            }
+
+            $methodCall->name = new Identifier('createStub');
+
+            return $node;
+        }
+
         $hasChanges = false;
 
         foreach ($node->getArgs() as $arg) {