[CodeQuality] Skip multiple uses variable as arg after defined on BareCreateMockAssignToDirectUseRector (#669)

* [CodeQuality] Skip multiple uses variable as arg after defined on BareCreateMockAssignToDirectUseRector

* [rector] Rector fixes

* fix

* more fixture

* final touch; rename fixture

* clean up

---------

Co-authored-by: GitHub Action <actions@github.com>

Author: samsonasik

rules-tests/CodeQuality/Rector/ClassMethod/BareCreateMockAssignToDirectUseRector/Fixture/multiple_uses_as_no_connection.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\BareCreateMockAssignToDirectUseRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class SkipMultipleUsesAsArg extends TestCase
+{
+    public function test()
+    {
+        $someMock = $this->createMock(\Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\BareCreateMockAssignToDirectUseRector\Source\AnotherClass::class);
+
+        // behaviour can already changed on first use
+        $this->useMock($someMock);
+        $this->useMockAgain($someMock);
+    }
+
+    private function useMock($someMock)
+    {
+        $someMock->method('someMethod');
+    }
+
+    private function useMockAgain($someMock)
+    {
+    }
+}

rules-tests/CodeQuality/Rector/ClassMethod/BareCreateMockAssignToDirectUseRector/Fixture/skip_multiple_uses_as_arg.php.inc

@@ -227,8 +227,7 @@ private function isUsedMoreOftenThanInCallLikeArgs(ClassMethod|Foreach_ $stmtsAw
             }
         }
 
-        // not suitable for direct replacing
-        return (count($foundVariables) - 1) > ($callLikeVariableUseCount);
+        return $callLikeVariableUseCount > 1 || (count($foundVariables) - 1) > $callLikeVariableUseCount;
     }
 
     /**