[rector] Rector fixes

Author: actions-user

rules/CodeQuality/NodeAnalyser/MockObjectExprDetector.php

@@ -78,7 +78,7 @@ public function isUsedInAssert(Expr $expr, ClassMethod $classMethod): bool
 
         foreach ($callLikes as $callLike) {
             $methodName = $this->nodeNameResolver->getName($callLike->name);
-            if (! str_starts_with($methodName, 'assert')) {
+            if (! str_starts_with((string) $methodName, 'assert')) {
                 continue;
             }
 

rules/PHPUnit120/Rector/ClassMethod/ExpressionCreateMockToCreateStubRector.php

@@ -7,16 +7,12 @@
 use PhpParser\Node;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\Assign;
-use PhpParser\Node\Expr\CallLike;
-use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Expression;
-use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\PHPUnit\CodeQuality\NodeAnalyser\AssignedMocksCollector;
 use Rector\PHPUnit\CodeQuality\NodeAnalyser\MockObjectExprDetector;
-use Rector\PHPUnit\CodeQuality\NodeFinder\VariableFinder;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -30,9 +26,7 @@ final class ExpressionCreateMockToCreateStubRector extends AbstractRector
     public function __construct(
         private readonly AssignedMocksCollector $assignedMocksCollector,
         private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
-        private readonly VariableFinder $variableFinder,
         private readonly MockObjectExprDetector $mockObjectExprDetector,
-        private readonly BetterNodeFinder $betterNodeFinder,
     ) {
     }
 
@@ -163,33 +157,4 @@ public function refactor(Node $node): ?ClassMethod
 
         return null;
     }
-
-    /**
-     * @param CallLike[] $callLikes
-     * @return Variable[]
-     */
-    private function collectVariableInCallLikeArg(array $callLikes, string $variableName): array
-    {
-        $callLikeUsedVariables = [];
-
-        foreach ($callLikes as $callLike) {
-            if ($callLike->isFirstClassCallable()) {
-                continue;
-            }
-
-            foreach ($callLike->getArgs() as $arg) {
-                if (! $arg->value instanceof Variable) {
-                    continue;
-                }
-
-                if (! $this->isName($arg->value, $variableName)) {
-                    continue;
-                }
-
-                $callLikeUsedVariables[] = $arg->value;
-            }
-        }
-
-        return $callLikeUsedVariables;
-    }
 }