[Alternative 1] Don't change to assertSame() on numeric string on AssertEqualsToSameRector (#520)

* [Alternative] Don't change to assertSame() on numeric string

* [Alternative] Don't change to assertSame() on numeric string

Author: samsonasik

rules/CodeQuality/Rector/MethodCall/AssertEqualsToSameRector.php

@@ -11,6 +11,7 @@
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Scalar\InterpolatedString;
+use PhpParser\Node\Scalar\String_;
 use PHPStan\Type\BooleanType;
 use PHPStan\Type\Constant\ConstantArrayType;
 use PHPStan\Type\Constant\ConstantBooleanType;
@@ -142,7 +143,11 @@ private function shouldSkipLooseComparison(array $args): bool
         }
 
         // can happen with magic process
-        return $secondArgType instanceof NeverType;
+        if ($secondArgType instanceof NeverType) {
+            return true;
+        }
+
+        return $args[0]->value instanceof String_ && is_numeric($args[0]->value->value);
     }
 
     private function shouldSkipConstantArrayType(Expr $expr): bool

tests/Issues/AssertEqualsSame/Fixture/assert_equals_numeric_string.php.inc

@@ -0,0 +1,45 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\Issues\AssertEqualsSame;
+
+use PHPUnit\Framework\TestCase;
+
+class AssertEquals extends TestCase
+{
+    public function test()
+    {
+        $this->assertEquals(123, $this->getOrderId());
+    }
+
+    private function getOrderId(): string
+    {
+        return '0000000000000000000123';
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\Issues\AssertEqualsSame;
+
+use PHPUnit\Framework\TestCase;
+
+class AssertEquals extends TestCase
+{
+    public function test()
+    {
+        $this->assertEquals('123', $this->getOrderId());
+    }
+
+    private function getOrderId(): string
+    {
+        return '0000000000000000000123';
+    }
+}
+
+?>