Skip to content

Commit 74914f2

Browse files
authored
cover interfaces in BareCreateMockAssignToDirectUseRector (#625)
1 parent 7023a3b commit 74914f2

File tree

3 files changed

+52
-4
lines changed

3 files changed

+52
-4
lines changed
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
<?php
2+
3+
namespace Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\BareCreateMockAssignToDirectUseRector\Fixture;
4+
5+
use PHPUnit\Framework\TestCase;
6+
use Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\BareCreateMockAssignToDirectUseRector\Source\SomeInterfaceToBeMocked;
7+
8+
final class CoverInterface extends TestCase
9+
{
10+
public function test()
11+
{
12+
$someMock = $this->createMock(SomeInterfaceToBeMocked::class);
13+
14+
$this->useMock($someMock);
15+
}
16+
17+
private function useMock($someMock)
18+
{
19+
}
20+
}
21+
22+
?>
23+
-----
24+
<?php
25+
26+
namespace Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\BareCreateMockAssignToDirectUseRector\Fixture;
27+
28+
use PHPUnit\Framework\TestCase;
29+
use Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\BareCreateMockAssignToDirectUseRector\Source\SomeInterfaceToBeMocked;
30+
31+
final class CoverInterface extends TestCase
32+
{
33+
public function test()
34+
{
35+
$this->useMock($this->createMock(SomeInterfaceToBeMocked::class));
36+
}
37+
38+
private function useMock($someMock)
39+
{
40+
}
41+
}
42+
43+
?>
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\BareCreateMockAssignToDirectUseRector\Source;
6+
7+
interface SomeInterfaceToBeMocked
8+
{
9+
}

rules/CodeQuality/NodeAnalyser/AssignedMocksCollector.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,6 @@ public function collect(ClassMethod|Foreach_ $stmtsAware): array
6868
continue;
6969
}
7070

71-
if ($mockClassReflection->isInterface()) {
72-
continue;
73-
}
74-
7571
$mockedVariableName = $this->nodeNameResolver->getName($assign->var);
7672
$mockedVariablesToTypes[$mockedVariableName] = $mockedClass;
7773
}

0 commit comments

Comments
 (0)