Skip to content

Commit 74fc298

Browse files
committed
Fix
1 parent bd96d32 commit 74fc298

2 files changed

Lines changed: 5 additions & 17 deletions

File tree

rules/PHPUnit90/Rector/MethodCall/SpecificAssertContainsWithoutIdentityRector.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,10 @@ public function refactor(Node $node): ?Node
9292
return null;
9393
}
9494

95+
if (count($node->getArgs()) < 2) {
96+
return null;
97+
}
98+
9599
// when second argument is string: do nothing
96100
$secondArgType = $this->getType($node->getArgs()[1]->value);
97101
if ($secondArgType instanceof StringType) {

src/NodeAnalyzer/TestsNodeAnalyzer.php

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
use PhpParser\Node;
88
use PhpParser\Node\Expr\MethodCall;
99
use PhpParser\Node\Expr\StaticCall;
10-
use PhpParser\Node\Expr\Variable;
1110
use PhpParser\Node\Stmt\ClassMethod;
1211
use PHPStan\Reflection\ClassReflection;
1312
use PHPStan\Type\ObjectType;
@@ -34,22 +33,7 @@ public function __construct(
3433

3534
public function isInTestClass(Node $node): bool
3635
{
37-
if ($node instanceof MethodCall && (! $node->var instanceof Variable || ! $this->nodeNameResolver->isName(
38-
$node->var,
39-
'this'
40-
))) {
41-
$classReflection = $this->reflectionResolver->resolveClassReflectionSourceObject($node);
42-
43-
// fluent call PHPUnit methods
44-
if ($classReflection instanceof ClassReflection && str_starts_with(
45-
$classReflection->getName(),
46-
'PHPUnit\\'
47-
)) {
48-
$classReflection = $this->reflectionResolver->resolveClassReflection($node);
49-
}
50-
} else {
51-
$classReflection = $this->reflectionResolver->resolveClassReflection($node);
52-
}
36+
$classReflection = $this->reflectionResolver->resolveClassReflection($node);
5337

5438
if (! $classReflection instanceof ClassReflection) {
5539
return false;

0 commit comments

Comments
 (0)