bump to PHP 8.3

TomasVotruba · TomasVotruba · commit 7c5fd4ee12a3 · 2026-01-16T14:45:59.000+01:00
diff --git a/.github/workflows/code_analysis.yaml b/.github/workflows/code_analysis.yaml
@@ -24,6 +24,14 @@ jobs:
                         name: 'Finalise classes'
                         run: vendor/bin/swiss-knife finalize-classes src rules tests
 
+                    -
+                        name: 'Composer Validate'
+                        run: composer validate
+
+                    -
+                        name: 'PHPStan'
+                        run: vendor/bin/phpstan
+
         name: ${{ matrix.actions.name }}
         runs-on: ubuntu-latest
         timeout-minutes: 10
@@ -34,7 +42,7 @@ jobs:
             -
                 uses: shivammathur/setup-php@v2
                 with:
-                    php-version: 8.2
+                    php-version: 8.3
                     coverage: none
 
             -   uses: "ramsey/composer-install@v2"
diff --git a/.github/workflows/code_analysis_reuslabe.yaml b/.github/workflows/code_analysis_reuslabe.yaml
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -21,7 +21,7 @@ jobs:
             -
                 uses: shivammathur/setup-php@v2
                 with:
-                    php-version: 8.2
+                    php-version: 8.3
                     coverage: none
 
             -   uses: "ramsey/composer-install@v2"
diff --git a/composer.json b/composer.json
@@ -4,16 +4,16 @@
     "license": "MIT",
     "description": "Rector upgrades rules for PHPUnit",
     "require": {
-        "php": ">=8.2"
+        "php": ">=8.3"
     },
     "require-dev": {
-        "phpecs/phpecs": "^2.2",
+        "symplify/easy-coding-standard": "^13.0",
         "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan": "^2.1.31",
         "phpstan/phpstan-deprecation-rules": "^2.0",
         "phpstan/phpstan-webmozart-assert": "^2.0",
         "phpunit/phpunit": "^11.5",
-        "rector/jack": "^0.4.0",
+        "rector/jack": "^0.5",
         "rector/rector-src": "dev-main",
         "rector/swiss-knife": "^1.0",
         "rector/type-perfect": "^2.1",
diff --git a/rules/AnnotationsToAttributes/Rector/ClassMethod/DataProviderAnnotationToAttributeRector.php b/rules/AnnotationsToAttributes/Rector/ClassMethod/DataProviderAnnotationToAttributeRector.php
@@ -30,10 +30,7 @@
  */
 final class DataProviderAnnotationToAttributeRector extends AbstractRector implements MinPhpVersionInterface
 {
-    /**
-     * @var string
-     */
-    private const DATA_PROVIDER_CLASS = 'PHPUnit\Framework\Attributes\DataProvider';
+    private const string DATA_PROVIDER_CLASS = 'PHPUnit\Framework\Attributes\DataProvider';
 
     public function __construct(
         private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
diff --git a/rules/AnnotationsToAttributes/Rector/ClassMethod/DependsAnnotationWithValueToAttributeRector.php b/rules/AnnotationsToAttributes/Rector/ClassMethod/DependsAnnotationWithValueToAttributeRector.php
@@ -27,10 +27,7 @@
  */
 final class DependsAnnotationWithValueToAttributeRector extends AbstractRector implements MinPhpVersionInterface
 {
-    /**
-     * @var string
-     */
-    private const DEPENDS_ATTRIBUTE = 'PHPUnit\Framework\Attributes\Depends';
+    private const string DEPENDS_ATTRIBUTE = 'PHPUnit\Framework\Attributes\Depends';
 
     public function __construct(
         private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
diff --git a/rules/AnnotationsToAttributes/Rector/ClassMethod/TestWithAnnotationToAttributeRector.php b/rules/AnnotationsToAttributes/Rector/ClassMethod/TestWithAnnotationToAttributeRector.php
@@ -30,10 +30,7 @@
  */
 final class TestWithAnnotationToAttributeRector extends AbstractRector implements MinPhpVersionInterface
 {
-    /**
-     * @var string
-     */
-    private const TEST_WITH_ATTRIBUTE = 'PHPUnit\Framework\Attributes\TestWith';
+    private const string TEST_WITH_ATTRIBUTE = 'PHPUnit\Framework\Attributes\TestWith';
 
     public function __construct(
         private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
diff --git a/rules/AnnotationsToAttributes/Rector/Class_/CoversAnnotationWithValueToAttributeRector.php b/rules/AnnotationsToAttributes/Rector/Class_/CoversAnnotationWithValueToAttributeRector.php
@@ -28,25 +28,13 @@
  */
 final class CoversAnnotationWithValueToAttributeRector extends AbstractRector implements MinPhpVersionInterface
 {
-    /**
-     * @var string
-     */
-    private const COVERS_FUNCTION_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversFunction';
+    private const string COVERS_FUNCTION_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversFunction';
 
-    /**
-     * @var string
-     */
-    private const COVERTS_CLASS_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversClass';
+    private const string COVERTS_CLASS_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversClass';
 
-    /**
-     * @var string
-     */
-    private const COVERTS_TRAIT_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversTrait';
+    private const string COVERTS_TRAIT_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversTrait';
 
-    /**
-     * @var string
-     */
-    private const COVERS_METHOD_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversMethod';
+    private const string COVERS_METHOD_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversMethod';
 
     public function __construct(
         private readonly PhpDocTagRemover $phpDocTagRemover,
diff --git a/rules/AnnotationsToAttributes/Rector/Class_/TicketAnnotationToAttributeRector.php b/rules/AnnotationsToAttributes/Rector/Class_/TicketAnnotationToAttributeRector.php
@@ -33,10 +33,7 @@
  */
 final class TicketAnnotationToAttributeRector extends AbstractRector implements MinPhpVersionInterface
 {
-    /**
-     * @var string
-     */
-    private const TICKET_CLASS = 'PHPUnit\Framework\Attributes\Ticket';
+    private const string TICKET_CLASS = 'PHPUnit\Framework\Attributes\Ticket';
 
     public function __construct(
         private readonly PhpDocTagRemover $phpDocTagRemover,
diff --git a/rules/CodeQuality/Enum/NonAssertNonStaticMethods.php b/rules/CodeQuality/Enum/NonAssertNonStaticMethods.php
@@ -9,7 +9,7 @@ final class NonAssertNonStaticMethods
     /**
      * @var string[]
      */
-    public const ALL = [
+    public const array ALL = [
         'createMock',
         'atLeast',
         'atLeastOnce',
diff --git a/rules/CodeQuality/NodeAnalyser/DoctrineEntityDocumentAnalyser.php b/rules/CodeQuality/NodeAnalyser/DoctrineEntityDocumentAnalyser.php
@@ -12,7 +12,7 @@
     /**
      * @var string[]
      */
-    private const ENTITY_DOCBLOCK_MARKERS = ['@Document', '@ORM\\Document', '@Entity', '@ORM\\Entity'];
+    private const array ENTITY_DOCBLOCK_MARKERS = ['@Document', '@ORM\\Document', '@Entity', '@ORM\\Entity'];
 
     public function isEntityClass(ClassReflection $classReflection): bool
     {
diff --git a/rules/CodeQuality/Rector/Class_/AddSeeTestAnnotationRector.php b/rules/CodeQuality/Rector/Class_/AddSeeTestAnnotationRector.php
@@ -23,10 +23,7 @@
  */
 final class AddSeeTestAnnotationRector extends AbstractRector
 {
-    /**
-     * @var string
-     */
-    private const SEE = 'see';
+    private const string SEE = 'see';
 
     public function __construct(
         private readonly ReflectionProvider $reflectionProvider,
diff --git a/rules/CodeQuality/Rector/Class_/TypeWillReturnCallableArrowFunctionRector.php b/rules/CodeQuality/Rector/Class_/TypeWillReturnCallableArrowFunctionRector.php
@@ -37,10 +37,7 @@
  */
 final class TypeWillReturnCallableArrowFunctionRector extends AbstractRector
 {
-    /**
-     * @var string
-     */
-    private const WILL_RETURN_CALLBACK = 'willReturnCallback';
+    private const string WILL_RETURN_CALLBACK = 'willReturnCallback';
 
     public function __construct(
         private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
diff --git a/rules/CodeQuality/Rector/MethodCall/AssertEqualsToSameRector.php b/rules/CodeQuality/Rector/MethodCall/AssertEqualsToSameRector.php
@@ -37,7 +37,7 @@ final class AssertEqualsToSameRector extends AbstractRector
     /**
      * @var array<string, string>
      */
-    private const RENAME_METHODS_MAP = [
+    private const array RENAME_METHODS_MAP = [
         'assertEquals' => 'assertSame',
         'assertNotEquals' => 'assertNotSame',
     ];
@@ -49,7 +49,12 @@ final class AssertEqualsToSameRector extends AbstractRector
      *
      * @var array<class-string<Type>>
      */
-    private const SCALAR_TYPES = [FloatType::class, IntegerType::class, StringType::class, ConstantArrayType::class];
+    private const array SCALAR_TYPES = [
+        FloatType::class,
+        IntegerType::class,
+        StringType::class,
+        ConstantArrayType::class,
+    ];
 
     public function __construct(
         private readonly IdentifierManipulator $identifierManipulator,
diff --git a/rules/CodeQuality/Rector/MethodCall/AssertFalseStrposToContainsRector.php b/rules/CodeQuality/Rector/MethodCall/AssertFalseStrposToContainsRector.php
@@ -22,7 +22,7 @@ final class AssertFalseStrposToContainsRector extends AbstractRector
     /**
      * @var array<string, string>
      */
-    private const RENAME_METHODS_MAP = [
+    private const array RENAME_METHODS_MAP = [
         'assertFalse' => 'assertStringNotContainsString',
         'assertNotFalse' => 'assertStringContainsString',
     ];
diff --git a/rules/CodeQuality/Rector/MethodCall/AssertInstanceOfComparisonRector.php b/rules/CodeQuality/Rector/MethodCall/AssertInstanceOfComparisonRector.php
@@ -27,7 +27,7 @@ final class AssertInstanceOfComparisonRector extends AbstractRector
     /**
      * @var array<string, string>
      */
-    private const RENAME_METHODS_MAP = [
+    private const array RENAME_METHODS_MAP = [
         'assertTrue' => 'assertInstanceOf',
         'assertFalse' => 'assertNotInstanceOf',
     ];
diff --git a/rules/CodeQuality/Rector/MethodCall/AssertNotOperatorRector.php b/rules/CodeQuality/Rector/MethodCall/AssertNotOperatorRector.php
@@ -23,7 +23,7 @@ final class AssertNotOperatorRector extends AbstractRector
     /**
      * @var array<string, string>
      */
-    private const RENAME_METHODS_MAP = [
+    private const array RENAME_METHODS_MAP = [
         'assertTrue' => 'assertFalse',
         'assertFalse' => 'assertTrue',
     ];
diff --git a/rules/CodeQuality/Rector/MethodCall/AssertRegExpRector.php b/rules/CodeQuality/Rector/MethodCall/AssertRegExpRector.php
@@ -28,25 +28,13 @@
  */
 final class AssertRegExpRector extends AbstractRector
 {
-    /**
-     * @var string
-     */
-    private const ASSERT_SAME = 'assertSame';
+    private const string ASSERT_SAME = 'assertSame';
 
-    /**
-     * @var string
-     */
-    private const ASSERT_EQUALS = 'assertEquals';
+    private const string ASSERT_EQUALS = 'assertEquals';
 
-    /**
-     * @var string
-     */
-    private const ASSERT_NOT_SAME = 'assertNotSame';
+    private const string ASSERT_NOT_SAME = 'assertNotSame';
 
-    /**
-     * @var string
-     */
-    private const ASSERT_NOT_EQUALS = 'assertNotEquals';
+    private const string ASSERT_NOT_EQUALS = 'assertNotEquals';
 
     public function __construct(
         private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
diff --git a/rules/CodeQuality/Rector/MethodCall/AssertTrueFalseToSpecificMethodRector.php b/rules/CodeQuality/Rector/MethodCall/AssertTrueFalseToSpecificMethodRector.php
@@ -26,7 +26,7 @@ final class AssertTrueFalseToSpecificMethodRector extends AbstractRector
     /**
      * @var array<string,array<array-key,string>>
      */
-    private const FUNCTION_NAME_WITH_ASSERT_METHOD_NAMES = [
+    private const array FUNCTION_NAME_WITH_ASSERT_METHOD_NAMES = [
         'is_readable' => ['is_readable', 'assertIsReadable', 'assertNotIsReadable'],
         'array_key_exists' => ['array_key_exists', 'assertArrayHasKey', 'assertArrayNotHasKey'],
         'array_search' => ['array_search', 'assertContains', 'assertNotContains'],
diff --git a/rules/CodeQuality/Rector/MethodCall/FlipAssertRector.php b/rules/CodeQuality/Rector/MethodCall/FlipAssertRector.php
@@ -24,7 +24,7 @@ final class FlipAssertRector extends AbstractRector
     /**
      * @var string[]
      */
-    private const METHOD_NAMES = [
+    private const array METHOD_NAMES = [
         'assertSame', 'assertNotSame', 'assertNotEquals', 'assertEquals', 'assertStringContainsString',
     ];
 
diff --git a/rules/CodeQuality/Rector/MethodCall/UseSpecificWillMethodRector.php b/rules/CodeQuality/Rector/MethodCall/UseSpecificWillMethodRector.php
@@ -23,7 +23,7 @@ final class UseSpecificWillMethodRector extends AbstractRector
     /**
      * @var array<string, string>
      */
-    private const NESTED_METHOD_TO_RENAME_MAP = [
+    private const array NESTED_METHOD_TO_RENAME_MAP = [
         'returnArgument' => 'willReturnArgument',
         'returnCallback' => 'willReturnCallback',
         'returnSelf' => 'willReturnSelf',
diff --git a/rules/PHPUnit100/Rector/MethodCall/PropertyExistsWithoutAssertRector.php b/rules/PHPUnit100/Rector/MethodCall/PropertyExistsWithoutAssertRector.php
@@ -26,7 +26,7 @@ final class PropertyExistsWithoutAssertRector extends AbstractRector
     /**
      * @var array<string, string>
      */
-    private const RENAME_METHODS_WITH_OBJECT_MAP = [
+    private const array RENAME_METHODS_WITH_OBJECT_MAP = [
         'assertClassHasAttribute' => 'assertTrue',
         'assertObjectHasAttribute' => 'assertTrue',
         'assertClassHasStaticAttribute' => 'assertTrue',
diff --git a/rules/PHPUnit120/Rector/Class_/AssertIsTypeMethodCallRector.php b/rules/PHPUnit120/Rector/Class_/AssertIsTypeMethodCallRector.php
@@ -21,7 +21,7 @@
  */
 final class AssertIsTypeMethodCallRector extends AbstractRector
 {
-    private const IS_TYPE_VALUE_TO_METHOD = [
+    private const array IS_TYPE_VALUE_TO_METHOD = [
         'array' => 'isArray',
         'bool' => 'isBool',
         'boolean' => 'isBool',
diff --git a/rules/PHPUnit60/Rector/ClassMethod/ExceptionAnnotationRector.php b/rules/PHPUnit60/Rector/ClassMethod/ExceptionAnnotationRector.php
@@ -29,7 +29,7 @@ final class ExceptionAnnotationRector extends AbstractRector
      *
      * @var array<string, string>
      */
-    private const ANNOTATION_TO_METHOD = [
+    private const array ANNOTATION_TO_METHOD = [
         'expectedExceptionMessageRegExp' => 'expectExceptionMessageRegExp',
         'expectedExceptionMessage' => 'expectExceptionMessage',
         'expectedExceptionCode' => 'expectExceptionCode',
diff --git a/rules/PHPUnit60/Rector/MethodCall/DelegateExceptionArgumentsRector.php b/rules/PHPUnit60/Rector/MethodCall/DelegateExceptionArgumentsRector.php
@@ -24,7 +24,7 @@ final class DelegateExceptionArgumentsRector extends AbstractRector
     /**
      * @var array<string, string>
      */
-    private const OLD_TO_NEW_METHOD = [
+    private const array OLD_TO_NEW_METHOD = [
         'setExpectedException' => 'expectExceptionMessage',
         'setExpectedExceptionRegExp' => 'expectExceptionMessageRegExp',
     ];
diff --git a/rules/PHPUnit60/Rector/MethodCall/GetMockBuilderGetMockToCreateMockRector.php b/rules/PHPUnit60/Rector/MethodCall/GetMockBuilderGetMockToCreateMockRector.php
@@ -22,7 +22,7 @@ final class GetMockBuilderGetMockToCreateMockRector extends AbstractRector
     /**
      * @var string[]
      */
-    private const USELESS_METHOD_NAMES = [
+    private const array USELESS_METHOD_NAMES = [
         'disableOriginalConstructor',
         'disableOriginalClone',
         'disableArgumentCloning',
diff --git a/rules/PHPUnit80/Rector/MethodCall/SpecificAssertContainsRector.php b/rules/PHPUnit80/Rector/MethodCall/SpecificAssertContainsRector.php
@@ -26,7 +26,7 @@ final class SpecificAssertContainsRector extends AbstractRector
     /**
      * @var array<string, string>
      */
-    private const OLD_TO_NEW_METHOD_NAMES = [
+    private const array OLD_TO_NEW_METHOD_NAMES = [
         'assertContains' => 'assertStringContainsString',
         'assertNotContains' => 'assertStringNotContainsString',
     ];
diff --git a/rules/PHPUnit80/Rector/MethodCall/SpecificAssertInternalTypeRector.php b/rules/PHPUnit80/Rector/MethodCall/SpecificAssertInternalTypeRector.php
@@ -25,7 +25,7 @@ final class SpecificAssertInternalTypeRector extends AbstractRector
     /**
      * @var array<string, string[]>
      */
-    private const TYPE_TO_METHOD = [
+    private const array TYPE_TO_METHOD = [
         'array' => ['assertIsArray', 'assertIsNotArray'],
         'bool' => ['assertIsBool', 'assertIsNotBool'],
         'boolean' => ['assertIsBool', 'assertIsNotBool'],
diff --git a/rules/PHPUnit90/Rector/Class_/TestListenerToHooksRector.php b/rules/PHPUnit90/Rector/Class_/TestListenerToHooksRector.php
@@ -27,7 +27,7 @@ final class TestListenerToHooksRector extends AbstractRector
     /**
      * @var array<string, array<class-string|string>>
      */
-    private const LISTENER_METHOD_TO_HOOK_INTERFACES = [
+    private const array LISTENER_METHOD_TO_HOOK_INTERFACES = [
         'addIncompleteTest' => ['PHPUnit\Runner\AfterIncompleteTestHook', 'executeAfterIncompleteTest'],
         'addRiskyTest' => ['PHPUnit\Runner\AfterRiskyTestHook', 'executeAfterRiskyTest'],
         'addSkippedTest' => ['PHPUnit\Runner\AfterSkippedTestHook', 'executeAfterSkippedTest'],
diff --git a/rules/PHPUnit90/Rector/MethodCall/ExplicitPhpErrorApiRector.php b/rules/PHPUnit90/Rector/MethodCall/ExplicitPhpErrorApiRector.php
@@ -26,7 +26,7 @@ final class ExplicitPhpErrorApiRector extends AbstractRector
     /**
      * @var array<string, string>
      */
-    private const REPLACEMENTS = [
+    private const array REPLACEMENTS = [
         'PHPUnit\Framework\TestCase\Notice' => 'expectNotice',
         'PHPUnit\Framework\TestCase\Deprecated' => 'expectDeprecation',
         'PHPUnit\Framework\TestCase\Error' => 'expectError',
diff --git a/rules/PHPUnit90/Rector/MethodCall/SpecificAssertContainsWithoutIdentityRector.php b/rules/PHPUnit90/Rector/MethodCall/SpecificAssertContainsWithoutIdentityRector.php
@@ -24,7 +24,7 @@ final class SpecificAssertContainsWithoutIdentityRector extends AbstractRector
     /**
      * @var array<string, array<string, string>>
      */
-    private const OLD_METHODS_NAMES_TO_NEW_NAMES = [
+    private const array OLD_METHODS_NAMES_TO_NEW_NAMES = [
         'string' => [
             'assertContains' => 'assertContainsEquals',
             'assertNotContains' => 'assertNotContainsEquals',
diff --git a/src/Enum/AssertMethod.php b/src/Enum/AssertMethod.php
diff --git a/src/Enum/BehatClassName.php b/src/Enum/BehatClassName.php
diff --git a/src/Enum/ConsecutiveMethodName.php b/src/Enum/ConsecutiveMethodName.php
diff --git a/src/Enum/ConsecutiveVariable.php b/src/Enum/ConsecutiveVariable.php
diff --git a/src/Enum/PHPUnitAttribute.php b/src/Enum/PHPUnitAttribute.php
diff --git a/src/Enum/PHPUnitClassName.php b/src/Enum/PHPUnitClassName.php
diff --git a/src/Enum/ProphecyClassName.php b/src/Enum/ProphecyClassName.php
diff --git a/src/NodeAnalyzer/AssertCallAnalyzer.php b/src/NodeAnalyzer/AssertCallAnalyzer.php
diff --git a/src/NodeFactory/MatcherInvocationCountMethodCallNodeFactory.php b/src/NodeFactory/MatcherInvocationCountMethodCallNodeFactory.php
diff --git a/src/Set/PHPUnitSetList.php b/src/Set/PHPUnitSetList.php

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ jobs:`
`21`	`21`	`-`
`22`	`22`	`uses: shivammathur/setup-php@v2`
`23`	`23`	`with:`
`24`		`- php-version: 8.2`
	`24`	`+ php-version: 8.3`
`25`	`25`	`coverage: none`
`26`	`26`
`27`	`27`	`- uses: "ramsey/composer-install@v2"`