fixup! fixup! fixup! fixup! add variable support to CreateStubOverCreateMockArgRector

Author: TomasVotruba

rules-tests/PHPUnit120/Rector/ClassMethod/ExpressionCreateMockToCreateStubRector/Fixture/handle_used_outside_arg.php.inc

@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\ClassMethod\ExpressionCreateMockToCreateStubRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit120\Rector\ClassMethod\ExpressionCreateMockToCreateStubRector\Source\ClassWithDependency;
+
+final class HandleUsedOutsideArg extends TestCase
+{
+    public function test()
+    {
+        $mock = $this->createMock(\stdClass::class);
+
+        if ($mock instanceof \stdClass) {
+            // do something
+        }
+
+        $someObject = new ClassWithDependency($mock);
+        $this->assertSame($mock, $someObject->getDependency());
+    }
+}
+
+?>
+-----
+    <?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\ClassMethod\ExpressionCreateMockToCreateStubRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit120\Rector\ClassMethod\ExpressionCreateMockToCreateStubRector\Source\ClassWithDependency;
+
+final class HandleUsedOutsideArg extends TestCase
+{
+    public function test()
+    {
+        $mock = $this->createMock(\stdClass::class);
+
+        if ($mock instanceof \stdClass) {
+            // do something
+        }
+
+        $someObject = new ClassWithDependency($mock);
+        $this->assertSame($mock, $someObject->getDependency());
+    }
+}
+
+?>
+

rules-tests/PHPUnit120/Rector/ClassMethod/ExpressionCreateMockToCreateStubRector/Fixture/skip_used_outside_arg.php.inc

@@ -147,9 +147,9 @@ public function refactor(Node $node): ?ClassMethod
             //                continue;
             //            }
 
-            if ($this->mockObjectExprDetector->isUsedInAssert($assign->var, $node)) {
-                continue;
-            }
+//            if ($this->mockObjectExprDetector->isUsedInAssert($assign->var, $node)) {
+//                continue;
+//            }
 
             $methodCall = $assign->expr;
             $methodCall->name = new Identifier('createStub');