add to setUp with only variables

Author: TomasVotruba

rules-tests/PHPUnit120/Rector/Class_/AllowMockObjectsWithoutExpectationsAttributeRector/Fixture/add_to_setup_when_no_expects_variable.php.inc

@@ -0,0 +1,50 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\Class_\AllowMockObjectsWithoutExpectationsAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AddToSetupWhenNoExpectsVariable extends TestCase
+{
+    protected function setUp(): void
+    {
+        $someMock = $this->createMock(\stdClass::class);
+        $someMock->method('some')->willReturn(true);
+    }
+
+    public function testOne()
+    {
+    }
+
+    public function testTwo()
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\Class_\AllowMockObjectsWithoutExpectationsAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+#[\PHPUnit\Framework\Attributes\AllowMockObjectsWithoutExpectations]
+final class AddToSetupWhenNoExpectsVariable extends TestCase
+{
+    protected function setUp(): void
+    {
+        $someMock = $this->createMock(\stdClass::class);
+        $someMock->method('some')->willReturn(true);
+    }
+
+    public function testOne()
+    {
+    }
+
+    public function testTwo()
+    {
+    }
+}
+
+?>

rules/PHPUnit120/Rector/Class_/AllowMockObjectsWithoutExpectationsAttributeRector.php

@@ -54,13 +54,9 @@ public function refactor(Node $node): ?Class_
             return null;
         }
 
+        // even for 0 mocked properties, the variable in setUp() can be mocked
         $mockObjectPropertyNames = $this->matchMockObjectPropertyNames($node);
 
-        // there are no mock object properties
-        if ($mockObjectPropertyNames === []) {
-            return null;
-        }
-
         $missedTestMethodsByMockPropertyName = [];
         $usingTestMethodsByMockPropertyName = [];
         $testMethodCount = 0;
@@ -89,7 +85,7 @@ public function refactor(Node $node): ?Class_
 
         // or find a ->method() calls on a setUp() mocked property
         $hasAnyMethodInSetup = $this->isMissingExpectsOnMockObjectMethodCallInSetUp($node);
-        if ($hasAnyMethodInSetup && $testMethodCount > 1) {
+        if ($hasAnyMethodInSetup) {
             $node->attrGroups[] = new AttributeGroup([
                 new Attribute(new FullyQualified(PHPUnitAttribute::ALLOW_MOCK_OBJECTS_WITHOUT_EXPECTATIONS)),
             ]);
@@ -284,6 +280,7 @@ private function isAtLeastOneMockPropertyMockedOnce(array $usingTestMethodsByMoc
     private function isMissingExpectsOnMockObjectMethodCallInSetUp(Class_ $class): bool
     {
         $setupClassMethod = $class->getMethod(MethodName::SET_UP);
+
         if (! $setupClassMethod instanceof ClassMethod) {
             return false;
         }
@@ -293,6 +290,7 @@ private function isMissingExpectsOnMockObjectMethodCallInSetUp(Class_ $class): b
             (array) $setupClassMethod->stmts,
             MethodCall::class
         );
+
         foreach ($methodCalls as $methodCall) {
             if (! $this->isName($methodCall->name, 'method')) {
                 continue;