[Phpunit12] Skip as Argument with required MockObject Type on CreateStubOverCreateMockArgRector

Author: samsonasik

rules-tests/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector/Fixture/handle_static_call.php.inc

@@ -3,7 +3,7 @@
 namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Fixture;
 
 use PHPUnit\Framework\TestCase;
-use Utils\PHPStan\Tests\Rule\PHPUnit\StubOverMockArgRule\Source\AnyClass;
+use Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Source\AnyClass;
 
 class HandleStaticCall extends TestCase
 {
@@ -22,7 +22,7 @@ class HandleStaticCall extends TestCase
 namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Fixture;
 
 use PHPUnit\Framework\TestCase;
-use Utils\PHPStan\Tests\Rule\PHPUnit\StubOverMockArgRule\Source\AnyClass;
+use Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Source\AnyClass;
 
 class HandleStaticCall extends TestCase
 {

rules-tests/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector/Fixture/skip_as_argument_with_mockobject_type.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Fixture;
+
+use DateTime;
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Source\SomeMockHelper;
+
+class SkipAsArgumentWithMockObjectType extends TestCase {
+    public function testFoo(): void
+    {
+        new SomeMockHelper($this->createMock(DateTime::class));
+    }
+}

rules-tests/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector/Fixture/skip_first_class_callable.php.inc

@@ -3,7 +3,7 @@
 namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Fixture;
 
 use PHPUnit\Framework\TestCase;
-use Utils\PHPStan\Tests\Rule\PHPUnit\StubOverMockArgRule\Source\AnyClass;
+use Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Source\AnyClass;
 
 class SkipFirstClassCallable extends TestCase
 {

rules-tests/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector/Fixture/some_file_with_mocks.php.inc

@@ -3,7 +3,7 @@
 namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Fixture;
 
 use PHPUnit\Framework\TestCase;
-use Utils\PHPStan\Tests\Rule\PHPUnit\StubOverMockArgRule\Source\AnyClass;
+use Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Source\AnyClass;
 
 class SomeFileWithMocks extends TestCase
 {
@@ -24,7 +24,7 @@ class SomeFileWithMocks extends TestCase
 namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Fixture;
 
 use PHPUnit\Framework\TestCase;
-use Utils\PHPStan\Tests\Rule\PHPUnit\StubOverMockArgRule\Source\AnyClass;
+use Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Source\AnyClass;
 
 class SomeFileWithMocks extends TestCase
 {

rules-tests/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector/Source/AnyClass.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Source;
+
+final class AnyClass
+{
+    public function run(...$params)
+    {
+    }
+
+    public static function staticRun(...$params)
+    {
+    }
+}

rules-tests/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector/Source/SomeMockHelper.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Source;
+
+use DateTime;
+use PHPUnit\Framework\MockObject\MockObject;
+
+class SomeMockHelper {
+    public function __construct(
+    	public MockObject&DateTime $i
+    ) {}
+
+    public function configureMock(array $data): void
+    {
+    }
+}

rules/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector.php

@@ -5,6 +5,7 @@
 namespace Rector\PHPUnit\PHPUnit120\Rector\CallLike;
 
 use PhpParser\Node;
+use PhpParser\Node\Arg;
 use PhpParser\Node\ArrayItem;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Assign;
@@ -15,9 +16,19 @@
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Expression;
+use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\Reflection\ParametersAcceptor;
+use PHPStan\Type\MixedType;
+use PHPStan\Type\ObjectType;
+use PHPStan\Type\Type;
+use Rector\NodeTypeResolver\PHPStan\ParametersAcceptorSelectorVariantsWrapper;
+use Rector\PHPStan\ScopeFetcher;
 use Rector\PHPUnit\CodeQuality\NodeAnalyser\MockObjectExprDetector;
+use Rector\PHPUnit\Enum\PHPUnitClassName;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\Rector\AbstractRector;
+use Rector\Reflection\ReflectionResolver;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -31,6 +42,7 @@ final class CreateStubOverCreateMockArgRector extends AbstractRector
     public function __construct(
         private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
         private readonly MockObjectExprDetector $mockObjectExprDetector,
+        private readonly ReflectionResolver $reflectionResolver
     ) {
     }
 
@@ -107,11 +119,27 @@ public function refactor(Node $node): MethodCall|StaticCall|New_|ArrayItem|Class
             return null;
         }
 
-        foreach ($node->getArgs() as $arg) {
+        $scope = ScopeFetcher::fetch($node);
+        $reflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($node);
+
+        if (! $reflection instanceof FunctionReflection && ! $reflection instanceof MethodReflection) {
+            return null;
+        }
+
+        $parametersAcceptor = ParametersAcceptorSelectorVariantsWrapper::select($reflection, $node, $scope);
+
+        foreach ($node->getArgs() as $key => $arg) {
             if (! $arg->value instanceof MethodCall) {
                 continue;
             }
 
+            $type = $this->resolveTypeFromArgumentAndKey($parametersAcceptor, $arg, $key);
+            $superType = new ObjectType(PHPUnitClassName::MOCK_OBJECT);
+
+            if ($superType->isSuperTypeOf($type)->yes()) {
+                continue;
+            }
+
             $methodCall = $arg->value;
             if (! $this->isName($methodCall->name, 'createMock')) {
                 continue;
@@ -128,6 +156,28 @@ public function refactor(Node $node): MethodCall|StaticCall|New_|ArrayItem|Class
         return null;
     }
 
+    private function resolveTypeFromArgumentAndKey(ParametersAcceptor $parametersAcceptor, Arg $arg, int $key): Type
+    {
+        $parameters = $parametersAcceptor->getParameters();
+        if (! $arg->name instanceof Identifier) {
+            if (! isset($parameters[$key])) {
+                return new MixedType();
+            }
+
+            return $parameters[$key]->getType();
+        }
+
+        foreach ($parameters as $parameter) {
+            if (! $parameter->getName() === $arg->name->name) {
+                continue;
+            }
+
+            return $parameter->getType();
+        }
+
+        return new MixedType();
+    }
+
     private function matchCreateMockMethodCall(Expr $expr): null|MethodCall
     {
         if (! $expr instanceof MethodCall) {