[CodeQuality] Ensure verify ClassReflection->hasConstructor() on MethodParametersAndReturnTypesResolver (#550)

Author: samsonasik

rules-tests/CodeQuality/Rector/MethodCall/ScalarArgumentToExpectedParamTypeRector/Fixture/skip_without_construct.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\ScalarArgumentToExpectedParamTypeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\ScalarArgumentToExpectedParamTypeRector\Source\ValueObjectWithoutConstructor;
+
+final class SkipWithoutConstruct extends TestCase
+{
+    public function test()
+    {
+        $valueObject = new ValueObjectWithoutConstructor(123.456, '123');
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/MethodCall/ScalarArgumentToExpectedParamTypeRector/Source/ValueObjectWithoutConstructor.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\ScalarArgumentToExpectedParamTypeRector\Source;
+
+final class ValueObjectWithoutConstructor
+{
+}

rules/CodeQuality/Reflection/MethodParametersAndReturnTypesResolver.php

@@ -81,6 +81,11 @@ public function resolveCallParameterTypes(MethodCall|StaticCall|New_ $callLike):
             }
 
             $classReflection = $this->reflectionProvider->getClass($className);
+
+            if (! $classReflection->hasConstructor()) {
+                return null;
+            }
+
             return $this->resolveParameterTypes($classReflection->getConstructor(), $classReflection);
         }
 
@@ -130,6 +135,11 @@ public function resolveCallParameterNames(MethodCall|StaticCall|New_ $callLike):
             }
 
             $classReflection = $this->reflectionProvider->getClass($className);
+
+            if (! $classReflection->hasConstructor()) {
+                return [];
+            }
+
             return $this->resolveParameterNames($classReflection->getConstructor());
         }