remove node traverser stop from AssertFuncCallToPHPUnitAssertRector

Author: TomasVotruba

rules-tests/CodeQuality/Rector/FuncCall/AssertFuncCallToPHPUnitAssertRector/Fixture/skip_in_static_method.php.inc

@@ -0,0 +1,38 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\FuncCall\AssertFuncCallToPHPUnitAssertRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class StaticAssertInStaticMethodTest extends TestCase
+{
+    private static function getExceptionMessage(string $fqcn): string
+    {
+        $exception = new $fqcn();
+        assert($exception instanceof \Exception);
+
+        return $exception->getMessage();
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\FuncCall\AssertFuncCallToPHPUnitAssertRector\Fixture;
+
+use PHPUnit\Framework\Assert;
+use PHPUnit\Framework\TestCase;
+
+final class StaticAssertInStaticMethodTest extends TestCase
+{
+    private static function getExceptionMessage(string $fqcn): string
+    {
+        $exception = new $fqcn();
+        Assert::assertInstanceOf($exception, \Exception::class);
+
+        return $exception->getMessage();
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/FuncCall/AssertFuncCallToPHPUnitAssertRector/Fixture/static_assert_in_static_method.php.inc

@@ -26,6 +26,7 @@
 use Rector\PHPStan\ScopeFetcher;
 use Rector\PHPUnit\Enum\AssertMethod;
 use Rector\PHPUnit\Enum\PHPUnitClassName;
+use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -36,7 +37,8 @@
 final class AssertFuncCallToPHPUnitAssertRector extends AbstractRector
 {
     public function __construct(
-        private readonly ValueResolver $valueResolver
+        private readonly ValueResolver $valueResolver,
+        private readonly TestsNodeAnalyzer $testsNodeAnalyzer
     ) {
     }
 
@@ -88,21 +90,26 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): StaticCall|MethodCall|null|int
     {
-        if ($node instanceof ClassMethod) {
-            if ($node->isStatic()) {
-                return NodeVisitor::DONT_TRAVERSE_CHILDREN;
-            }
-
-            return null;
-        }
-
-        if ($node instanceof Closure) {
-            if ($node->static) {
-                return NodeVisitor::DONT_TRAVERSE_CHILDREN;
-            }
-
-            return null;
-        }
+        // @todo handle only in test classes!
+
+        // most liekly hook to ClassMethod :) + traverse then
+        $this->testsNodeAnalyzer->isInTestClass($node);
+
+//        if ($node instanceof ClassMethod) {
+//            if ($node->isStatic()) {
+//                return NodeVisitor::DONT_TRAVERSE_CHILDREN;
+//            }
+//
+//            return null;
+//        }
+
+//        if ($node instanceof Closure) {
+//            if ($node->static) {
+//                return NodeVisitor::DONT_TRAVERSE_CHILDREN;
+//            }
+//
+//            return null;
+//        }
 
         if ($node->isFirstClassCallable()) {
             return null;