ReplaceTestAnnotationWithPrefixedFunctionRector does not match @test annotation if it is being part of string (#671)

* ReplaceTestAnnotationWithPrefixedFunctionRector does not match @test annotation if being part of string

* NewLineSplitter used instead of PHP_EOL explode

* Added break to avoid unnecessary foreach iteration

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

---------

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

Author: Dukecz

rules-tests/CodeQuality/Rector/ClassMethod/ReplaceTestAnnotationWithPrefixedFunctionRector/Fixture/skip_test_annotation_as_part_of_text.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\ReplaceTestAnnotationWithPrefixedFunctionRector\Fixture;
+
+class SkipTestAnnotationAsPartOfText extends \PHPUnit\Framework\TestCase
+{
+    /**
+     * there is some comment with something@test
+     * @test-different-annotation
+     */
+    public function onePlusOneShouldBeTwo()
+    {
+        $this->assertSame(2, 1+1);
+    }
+}
+
+?>

rules/CodeQuality/Rector/ClassMethod/ReplaceTestAnnotationWithPrefixedFunctionRector.php

@@ -12,8 +12,10 @@
 use Rector\Comments\NodeDocBlock\DocBlockUpdater;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\Rector\AbstractRector;
+use Rector\Util\NewLineSplitter;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use function in_array;
 
 /**
  * @see \Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\ReplaceTestAnnotationWithPrefixedFunctionRector\ReplaceTestAnnotationWithPrefixedFunctionRectorTest
@@ -84,7 +86,15 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if (! str_contains($docComment->getText(), '@test')) {
+        $hasAnnotation = false;
+        foreach(NewLineSplitter::split($docComment->getText()) as $row) {
+            if (in_array(trim($row), ['*@test', '* @test'])) {
+                $hasAnnotation = true;
+                break;
+            }
+        }
+
+        if (! $hasAnnotation) {
             return null;
         }