Improve rule definitions#706
Conversation
simonschaufi
commented
Jul 10, 2026
simonschaufi
commented
- Use active voice
- Remove final fullstop
- Use code style
| public function getRuleDefinition(): RuleDefinition | ||
| { | ||
| return new RuleDefinition('Refactor deprecated withConsecutive() to willReturnCallback() structure', [ | ||
| return new RuleDefinition('Refactor deprecated `withConsecutive()` to `willReturnCallback()` structure', [ |
There was a problem hiding this comment.
Can you do typos first and leave this function names wrap for next round? I find it hard to review and not sure about this change.
There was a problem hiding this comment.
Hmm, that will also make it hatte for me and create a lot of extra time to split into another PR. These changes already took me a lot of time and now I need to go through all rules again? I did these kind of changes already before and they went through without causing much trouble in another repo.
- Use active voice - Remove final fullstop - Use code style
e460abe to
0ceb76d
Compare
|
@TomasVotruba how can we move forward? |
|
I've decided to keep it as it is. It's more human readable and its just code samples, not real code. |
|
Sorry but I don't understand it just like that. I parse the files and use that like actually for commit messages and I want my commit messages to be clear. I've invested a lot of time into unifying the commit message also in the past in the main rector repository and some messages are even completely wrong. |
2 participants
