-
-
Notifications
You must be signed in to change notification settings - Fork 440
Expand file tree
/
Copy pathFluentSettersToStandaloneCallMethodRector.php
More file actions
177 lines (148 loc) · 4.67 KB
/
FluentSettersToStandaloneCallMethodRector.php
File metadata and controls
177 lines (148 loc) · 4.67 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
<?php
declare(strict_types=1);
namespace Rector\Unambiguous\Rector\Expression;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\New_;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Name;
use PhpParser\Node\Stmt\Expression;
use PhpParser\Node\Stmt\Return_;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Type\ObjectType;
use Rector\Naming\Naming\PropertyNaming;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @experimental since 2025-11
*
* @see \Rector\Tests\Unambiguous\Rector\Expression\FluentSettersToStandaloneCallMethodRector\FluentSettersToStandaloneCallMethodRectorTest
*/
final class FluentSettersToStandaloneCallMethodRector extends AbstractRector
{
public function __construct(
private readonly PropertyNaming $propertyNaming
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Change fluent setter chain calls, to standalone line of setters',
[
new CodeSample(
<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
return (new SomeFluentClass())
->setName('John')
->setAge(30);
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
$someFluentClass = new SomeFluentClass();
$someFluentClass->setName('John');
$someFluentClass->setAge(30);
return $someFluentClass;
}
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [Expression::class, Return_::class];
}
/**
* @param Expression|Return_ $node
*/
public function refactor(Node $node): ?array
{
if (! $node->expr instanceof MethodCall) {
return null;
}
$firstMethodCall = $node->expr;
// must be nested method call, so we avoid only single one
if (! $firstMethodCall->var instanceof MethodCall) {
return null;
}
/** @var MethodCall[] $methodCalls */
$methodCalls = [];
$currentMethodCall = $firstMethodCall;
while ($currentMethodCall instanceof MethodCall) {
// must be exactly one argument
if (count($currentMethodCall->getArgs()) !== 1) {
return null;
}
$methodCalls[] = $currentMethodCall;
$currentMethodCall = $currentMethodCall->var;
}
// at least 2 method calls
if (count($methodCalls) < 1) {
return null;
}
$rootExpr = $currentMethodCall;
if ($this->shouldSkipForVendorOrInternal($firstMethodCall)) {
return null;
}
$variableName = $this->resolveVariableName($rootExpr);
$someVariable = new Variable($variableName);
$firstAssign = new Assign($someVariable, $rootExpr);
$stmts = [new Expression($firstAssign)];
// revert to normal order
$methodCalls = array_reverse($methodCalls);
foreach ($methodCalls as $methodCall) {
$methodCall->var = $someVariable;
// inlines indent and removes () around first expr
$methodCall->setAttribute(AttributeKey::ORIGINAL_NODE, null);
$stmts[] = new Expression($methodCall);
}
if ($node instanceof Return_) {
$node->expr = $someVariable;
$stmts[] = $node;
}
$node->expr = $someVariable;
return $stmts;
}
private function resolveVariableName(Expr $expr): string
{
if (! $expr instanceof New_) {
return 'someVariable';
}
if ($expr->class instanceof Name) {
return $this->propertyNaming->fqnToVariableName($expr->class);
}
return 'someVariable';
}
private function shouldSkipForVendorOrInternal(MethodCall $firstMethodCall): bool
{
$callerType = $this->getType($firstMethodCall);
if ($callerType instanceof ObjectType) {
$classReflection = $callerType->getClassReflection();
if (! $classReflection instanceof ClassReflection) {
return false;
}
$fileName = $classReflection->getFileName();
if ($fileName === null || str_contains($fileName, 'vendor')) {
return true;
}
}
return false;
}
}