-
-
Notifications
You must be signed in to change notification settings - Fork 440
Expand file tree
/
Copy pathRemoveFinfoBufferContextArgRector.php
More file actions
130 lines (107 loc) · 3.74 KB
/
RemoveFinfoBufferContextArgRector.php
File metadata and controls
130 lines (107 loc) · 3.74 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
<?php
declare(strict_types=1);
namespace Rector\Php85\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Identifier;
use PHPStan\Type\ObjectType;
use Rector\NodeAnalyzer\ArgsAnalyzer;
use Rector\Rector\AbstractRector;
use Rector\ValueObject\PhpVersionFeature;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_context_parameter_for_finfo_buffer
* @see \Rector\Tests\Php85\Rector\FuncCall\RemoveFinfoBufferContextArgRector\RemoveFinfoBufferContextArgRectorTest
*/
final class RemoveFinfoBufferContextArgRector extends AbstractRector implements MinPhpVersionInterface
{
public function __construct(
private readonly ArgsAnalyzer $argsAnalyzer,
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Remove argument by position by function name', [
new CodeSample(
<<<'CODE_SAMPLE'
finfo_buffer($finfo, $fileContents, FILEINFO_NONE, []);
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
finfo_buffer($finfo, $fileContents, FILEINFO_NONE);
CODE_SAMPLE
,
),
]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [FuncCall::class, MethodCall::class];
}
/**
* @param MethodCall|FuncCall $node
*/
public function refactor(Node $node): ?Node
{
// Cannot handle variadic args
if ($node->isFirstClassCallable()) {
return null;
}
if ($node instanceof FuncCall && ! $this->isName($node->name, 'finfo_buffer')) {
return null;
}
$objectType = new ObjectType('finfo');
if ($node instanceof MethodCall && (! $this->nodeTypeResolver->isObjectType(
$node->var,
$objectType
) || ! $this->isName($node->name, 'buffer'))) {
return null;
}
if ($this->removeContextArg($node)) {
return $node;
}
return null;
}
public function provideMinPhpVersion(): int
{
return PhpVersionFeature::DEPRECATE_FINFO_BUFFER_CONTEXT;
}
private function removeContextArg(FuncCall|MethodCall $callLike): bool
{
// In `finfo::buffer` method calls, the first parameter, compared to `finfo_buffer`, does not exist.
$methodArgCorrection = 0;
if ($callLike instanceof MethodCall) {
$methodArgCorrection = -1;
}
if (count($callLike->args) <= 2 + $methodArgCorrection) {
return false;
}
$args = $callLike->getArgs();
// Argument 3 ($flags) and argument 4 ($context) are optional, thus named parameters must be considered
if (! $this->argsAnalyzer->hasNamedArg($args)) {
if (count($args) < 4 + $methodArgCorrection) {
return false;
}
unset($callLike->args[3 + $methodArgCorrection]);
// update indexed to make printer work as expected
$callLike->args = array_values($callLike->args);
return true;
}
// process named arguments
foreach ($args as $position => $arg) {
if ($arg->name instanceof Identifier && $this->isName($arg->name, 'context')) {
unset($callLike->args[$position]);
// update indexed to make printer work as expected
$callLike->args = array_values($callLike->args);
return true;
}
}
return false;
}
}