-
-
Notifications
You must be signed in to change notification settings - Fork 440
Expand file tree
/
Copy pathRemoveUnusedClosureVariableUseRector.php
More file actions
98 lines (79 loc) · 2.3 KB
/
RemoveUnusedClosureVariableUseRector.php
File metadata and controls
98 lines (79 loc) · 2.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
<?php
declare(strict_types=1);
namespace Rector\DeadCode\Rector\Concat;
use PhpParser\Node;
use PhpParser\Node\Expr\Closure;
use Rector\DeadCode\NodeAnalyzer\ExprUsedInNodeAnalyzer;
use Rector\PhpParser\Node\BetterNodeFinder;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\DeadCode\Rector\Closure\RemoveUnusedClosureVariableUseRector\RemoveUnusedClosureVariableUseRectorTest
*/
final class RemoveUnusedClosureVariableUseRector extends AbstractRector
{
public function __construct(
private readonly BetterNodeFinder $betterNodeFinder,
private readonly ExprUsedInNodeAnalyzer $exprUsedInNodeAnalyzer
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Remove unused variable in use() of closure', [
new CodeSample(
<<<'CODE_SAMPLE'
$var = 1;
$closure = function() use ($var) {
echo 'Hello World';
};
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
$var = 1;
$closure = function() {
echo 'Hello World';
};
CODE_SAMPLE
),
]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [Closure::class];
}
/**
* @param Closure $node
*/
public function refactor(Node $node): ?Node
{
if ($node->uses === []) {
return null;
}
$hasChanged = false;
foreach ($node->uses as $key => $useVariable) {
$useVariableName = $this->getName($useVariable->var);
if (! is_string($useVariableName)) {
continue;
}
$isUseUsed = (bool) $this->betterNodeFinder->findFirst(
$node->stmts,
fn (Node $subNode): bool => $this->exprUsedInNodeAnalyzer->isUsed($subNode, $useVariable->var)
);
if ($isUseUsed) {
continue;
}
unset($node->uses[$key]);
$hasChanged = true;
}
if ($hasChanged) {
// reset keys, to keep as expected
$node->uses = array_values($node->uses);
return $node;
}
return null;
}
}