-
-
Notifications
You must be signed in to change notification settings - Fork 439
Expand file tree
/
Copy pathPrivatizeFinalClassMethodRector.php
More file actions
164 lines (140 loc) · 4.52 KB
/
PrivatizeFinalClassMethodRector.php
File metadata and controls
164 lines (140 loc) · 4.52 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
<?php
declare(strict_types=1);
namespace Rector\Privatization\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use PHPStan\Reflection\ClassReflection;
use Rector\PhpParser\Node\BetterNodeFinder;
use Rector\PHPStan\ScopeFetcher;
use Rector\Privatization\Guard\LaravelModelGuard;
use Rector\Privatization\Guard\OverrideByParentClassGuard;
use Rector\Privatization\Guard\ParentClassMagicCallGuard;
use Rector\Privatization\NodeManipulator\VisibilityManipulator;
use Rector\Privatization\VisibilityGuard\ClassMethodVisibilityGuard;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector\PrivatizeFinalClassMethodRectorTest
*/
final class PrivatizeFinalClassMethodRector extends AbstractRector
{
public function __construct(
private readonly ClassMethodVisibilityGuard $classMethodVisibilityGuard,
private readonly VisibilityManipulator $visibilityManipulator,
private readonly OverrideByParentClassGuard $overrideByParentClassGuard,
private readonly BetterNodeFinder $betterNodeFinder,
private readonly LaravelModelGuard $laravelModelGuard,
private readonly ParentClassMagicCallGuard $parentClassMagicCallGuard,
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Change protected class method to private if possible',
[
new CodeSample(
<<<'CODE_SAMPLE'
final class SomeClass
{
protected function someMethod()
{
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
final class SomeClass
{
private function someMethod()
{
}
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [Class_::class];
}
/**
* @param Class_ $node
*/
public function refactor(Node $node): ?Node
{
if (! $node->isFinal()) {
return null;
}
if (! $this->overrideByParentClassGuard->isLegal($node)) {
return null;
}
$scope = ScopeFetcher::fetch($node);
$classReflection = $scope->getClassReflection();
if (! $classReflection instanceof ClassReflection) {
return null;
}
$hasChanged = false;
foreach ($node->getMethods() as $classMethod) {
if ($this->shouldSkipClassMethod($classMethod)) {
continue;
}
if ($this->laravelModelGuard->isProtectedMethod($classReflection, $classMethod)) {
continue;
}
if ($this->classMethodVisibilityGuard->isClassMethodVisibilityGuardedByParent(
$classMethod,
$classReflection
)) {
continue;
}
if ($this->classMethodVisibilityGuard->isClassMethodVisibilityGuardedByTrait(
$classMethod,
$classReflection
)) {
continue;
}
if ($this->parentClassMagicCallGuard->containsParentClassMagicCall($node)) {
continue;
}
$this->visibilityManipulator->makePrivate($classMethod);
$hasChanged = true;
}
if ($hasChanged) {
return $node;
}
return null;
}
private function shouldSkipClassMethod(ClassMethod $classMethod): bool
{
// edge case in nette framework
/** @var string $methodName */
$methodName = $this->getName($classMethod->name);
if (str_starts_with($methodName, 'createComponent')) {
return true;
}
if (! $classMethod->isProtected()) {
return true;
}
if ($classMethod->isMagic()) {
return true;
}
// if has parent call, its probably overriding parent one → skip it
$hasParentCall = (bool) $this->betterNodeFinder->findFirst(
(array) $classMethod->stmts,
function (Node $node): bool {
if (! $node instanceof StaticCall) {
return false;
}
return $this->isName($node->class, 'parent');
}
);
return $hasParentCall;
}
}