-
-
Notifications
You must be signed in to change notification settings - Fork 439
Expand file tree
/
Copy pathSingleInArrayToCompareRector.php
More file actions
154 lines (130 loc) · 3.88 KB
/
SingleInArrayToCompareRector.php
File metadata and controls
154 lines (130 loc) · 3.88 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
<?php
declare(strict_types=1);
namespace Rector\CodeQuality\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\ArrayItem;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\BinaryOp\Equal;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\BinaryOp\NotEqual;
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
use PhpParser\Node\Expr\BooleanNot;
use PhpParser\Node\Expr\FuncCall;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodeQuality\Rector\FuncCall\SingleInArrayToCompareRector\SingleInArrayToCompareRectorTest
*/
final class SingleInArrayToCompareRector extends AbstractRector
{
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Changes in_array() with single element to ===',
[
new CodeSample(
<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
if (in_array(strtolower($type), ['$this'], true)) {
return strtolower($type);
}
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
if (strtolower($type) === '$this') {
return strtolower($type);
}
}
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [BooleanNot::class, FuncCall::class];
}
/**
* @param BooleanNot|FuncCall $node
*/
public function refactor(Node $node): ?Node
{
if ($node instanceof BooleanNot) {
if (! $node->expr instanceof FuncCall) {
return null;
}
$firstArrayItem = $this->resolveArrayItem($node->expr);
if (! $firstArrayItem instanceof ArrayItem) {
return null;
}
return $this->processCompare($firstArrayItem, $node->expr, true);
}
$firstArrayItem = $this->resolveArrayItem($node);
if (! $firstArrayItem instanceof ArrayItem) {
return null;
}
return $this->processCompare($firstArrayItem, $node);
}
private function resolveArrayItem(FuncCall $funcCall): ?ArrayItem
{
if (! $this->isName($funcCall, 'in_array')) {
return null;
}
if ($funcCall->isFirstClassCallable()) {
return null;
}
if (! isset($funcCall->args[1])) {
return null;
}
if (! $funcCall->args[1] instanceof Arg) {
return null;
}
if (! $funcCall->args[1]->value instanceof Array_) {
return null;
}
$arrayNode = $funcCall->args[1]->value;
if (count($arrayNode->items) !== 1) {
return null;
}
$firstArrayItem = $arrayNode->items[0];
if (! $firstArrayItem instanceof ArrayItem) {
return null;
}
if ($firstArrayItem->unpack) {
return null;
}
if (! isset($funcCall->getArgs()[0])) {
return null;
}
return $firstArrayItem;
}
private function processCompare(ArrayItem $firstArrayItem, FuncCall $funcCall, bool $isNegated = false): Node
{
$firstArrayItemValue = $firstArrayItem->value;
$firstArg = $funcCall->getArgs()[0];
// strict
if (isset($funcCall->getArgs()[2])) {
return $isNegated
? new NotIdentical($firstArg->value, $firstArrayItemValue)
: new Identical($firstArg->value, $firstArrayItemValue);
}
return $isNegated
? new NotEqual($firstArg->value, $firstArrayItemValue)
: new Equal($firstArg->value, $firstArrayItemValue);
}
}