-
-
Notifications
You must be signed in to change notification settings - Fork 439
Expand file tree
/
Copy pathMinMaxToClampRector.php
More file actions
161 lines (130 loc) · 4.31 KB
/
MinMaxToClampRector.php
File metadata and controls
161 lines (130 loc) · 4.31 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
<?php
declare(strict_types=1);
namespace Rector\Php86\Rector\FuncCall;
use PhpParser\Node\Identifier;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\FuncCall;
use Rector\Rector\AbstractRector;
use Rector\ValueObject\PhpVersionFeature;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\Php86\Rector\FuncCall\MinMaxToClampRector\MinMaxToClampRectorTest
*/
final class MinMaxToClampRector extends AbstractRector implements MinPhpVersionInterface
{
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Convert nested min()/max() calls to clamp()', [
new CodeSample(
<<<'CODE_SAMPLE'
$result = max(0, min(100, $value));
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
$result = clamp($value, 0, 100);
CODE_SAMPLE
),
]);
}
public function getNodeTypes(): array
{
return [FuncCall::class];
}
/**
* @param FuncCall $node
*/
public function refactor(Node $node): ?Node
{
if ($node->isFirstClassCallable()) {
return null;
}
if ($this->isName($node, 'max')) {
return $this->matchClampFuncCall($node, 'min');
}
if ($this->isName($node, 'min')) {
return $this->matchClampFuncCall($node, 'max');
}
return null;
}
public function provideMinPhpVersion(): int
{
return PhpVersionFeature::CLAMP;
}
private function matchClampFuncCall(FuncCall $outerFuncCall, string $expectedInnerFuncName): ?FuncCall
{
$args = $outerFuncCall->getArgs();
if (count($args) !== 2) {
return null;
}
if (! $this->isSupportedArg($args[0]) || ! $this->isSupportedArg($args[1])) {
return null;
}
$leftValue = $args[0]->value;
$rightValue = $args[1]->value;
if ($leftValue instanceof FuncCall) {
return $this->createClampFuncCall($outerFuncCall, $leftValue, $rightValue, $expectedInnerFuncName);
}
if ($rightValue instanceof FuncCall) {
return $this->createClampFuncCall($outerFuncCall, $rightValue, $leftValue, $expectedInnerFuncName);
}
return null;
}
private function createClampFuncCall(
FuncCall $outerFuncCall,
FuncCall $innerFuncCall,
Expr $outerBoundExpr,
string $expectedInnerFuncName
): ?FuncCall {
if ($innerFuncCall->isFirstClassCallable()) {
return null;
}
if (! $this->isName($innerFuncCall, $expectedInnerFuncName)) {
return null;
}
$args = $innerFuncCall->getArgs();
if (count($args) !== 2) {
return null;
}
if (! $this->isSupportedArg($args[0]) || ! $this->isSupportedArg($args[1])) {
return null;
}
$valueAndBound = $this->matchValueAndKnownBound($args[0]->value, $args[1]->value);
if ($valueAndBound === null) {
return null;
}
[$valueExpr, $innerBoundExpr] = $valueAndBound;
if ($this->isName($outerFuncCall, 'max')) {
return $this->nodeFactory->createFuncCall('clamp', [$valueExpr, $outerBoundExpr, $innerBoundExpr]);
}
return $this->nodeFactory->createFuncCall('clamp', [$valueExpr, $innerBoundExpr, $outerBoundExpr]);
}
private function isSupportedArg(Arg $arg): bool
{
return ! $arg->unpack && !$arg->name instanceof Identifier;
}
/**
* @return array{Expr, Expr}|null
*/
private function matchValueAndKnownBound(Expr $firstExpr, Expr $secondExpr): ?array
{
$isFirstKnownBound = $this->isKnownBound($firstExpr);
$isSecondKnownBound = $this->isKnownBound($secondExpr);
if ($isFirstKnownBound === $isSecondKnownBound) {
return null;
}
if ($isFirstKnownBound) {
return [$secondExpr, $firstExpr];
}
return [$firstExpr, $secondExpr];
}
private function isKnownBound(Expr $expr): bool
{
return $this->getNativeType($expr)
->isConstantScalarValue()
->yes();
}
}