[Php84] Add NewMethodCallWithoutParenthesesRector (#6802)

* [Php84] Add NewMethodCallWithoutParenthesesRector

* [Php84] Add NewMethodCallWithoutParenthesesRector

* implemented

* implemented

Author: samsonasik

config/set/php84.php

@@ -5,10 +5,11 @@
 use Rector\Config\RectorConfig;
 use Rector\Php84\Rector\FuncCall\AddEscapeArgumentRector;
 use Rector\Php84\Rector\FuncCall\RoundingModeEnumRector;
+use Rector\Php84\Rector\MethodCall\NewMethodCallWithoutParenthesesRector;
 use Rector\Php84\Rector\Param\ExplicitNullableParamTypeRector;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->rules(
-        [ExplicitNullableParamTypeRector::class, RoundingModeEnumRector::class, AddEscapeArgumentRector::class]
+        [ExplicitNullableParamTypeRector::class, RoundingModeEnumRector::class, AddEscapeArgumentRector::class, NewMethodCallWithoutParenthesesRector::class]
     );
 };

rules-tests/Php84/Rector/MethodCall/NewMethodCallWithoutParenthesesRector/Fixture/fixture.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\Php84\Rector\MethodCall\NewMethodCallWithoutParenthesesRector\Fixture;
+
+final class Fixture
+{
+    public function run()
+    {
+        (new Request())->withMethod('GET')->withUri('/hello-world');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php84\Rector\MethodCall\NewMethodCallWithoutParenthesesRector\Fixture;
+
+final class Fixture
+{
+    public function run()
+    {
+        new Request()->withMethod('GET')->withUri('/hello-world');
+    }
+}
+
+?>

rules-tests/Php84/Rector/MethodCall/NewMethodCallWithoutParenthesesRector/Fixture/skip_without_parentheses.php.inc

@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\Tests\Php84\Rector\MethodCall\NewMethodCallWithoutParenthesesRector\Fixture;
+
+final class SkipWithoutParentheses
+{
+    public function run()
+    {
+        new Request()->withMethod('GET')->withUri('/hello-world');
+    }
+}
+

rules-tests/Php84/Rector/MethodCall/NewMethodCallWithoutParenthesesRector/NewMethodCallWithoutParenthesesRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php84\Rector\MethodCall\NewMethodCallWithoutParenthesesRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class NewMethodCallWithoutParenthesesRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/Php84/Rector/MethodCall/NewMethodCallWithoutParenthesesRector/config/configured_rule.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Php84\Rector\MethodCall\NewMethodCallWithoutParenthesesRector;
+use Rector\ValueObject\PhpVersion;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(NewMethodCallWithoutParenthesesRector::class);
+
+    $rectorConfig->phpVersion(PhpVersion::PHP_84);
+};

rules/Php84/Rector/MethodCall/NewMethodCallWithoutParenthesesRector.php

@@ -0,0 +1,82 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Php84\Rector\MethodCall;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\New_;
+use Rector\Rector\AbstractRector;
+use Rector\ValueObject\PhpVersionFeature;
+use Rector\VersionBonding\Contract\MinPhpVersionInterface;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+/**
+ * @see \Rector\Tests\Php84\Rector\MethodCall\NewMethodCallWithoutParenthesesRector\NewMethodCallWithoutParenthesesRectorTest
+ */
+final class NewMethodCallWithoutParenthesesRector extends AbstractRector implements MinPhpVersionInterface
+{
+    /**
+     * @return array<class-string<Node>>
+     */
+    public function getNodeTypes(): array
+    {
+        return [MethodCall::class];
+    }
+
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition(
+            'Remove parentheses on new method call with parentheses',
+            [
+                new CodeSample(
+                    <<<'CODE_SAMPLE'
+(new Request())->withMethod('GET')->withUri('/hello-world');
+CODE_SAMPLE
+                    ,
+                    <<<'CODE_SAMPLE'
+new Request()->withMethod('GET')->withUri('/hello-world');
+CODE_SAMPLE
+                ),
+            ]
+        );
+    }
+
+    /**
+     * @param MethodCall $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if (! $node->var instanceof New_) {
+            return null;
+        }
+
+        $oldTokens = $this->file->getOldTokens();
+
+        // start node
+        if (! isset($oldTokens[$node->getStartTokenPos()])) {
+            return null;
+        }
+
+        // end of "var" node
+        if (! isset($oldTokens[$node->var->getEndTokenPos()])) {
+            return null;
+        }
+
+        if ((string) $oldTokens[$node->getStartTokenPos()] === '(' && (string) $oldTokens[$node->var->getEndTokenPos()] === ')') {
+            $oldTokens[$node->getStartTokenPos()]->text = '';
+            $oldTokens[$node->var->getEndTokenPos()]->text = '';
+
+            return $node;
+        }
+
+        return null;
+    }
+
+    public function provideMinPhpVersion(): int
+    {
+        return PhpVersionFeature::NEW_METHOD_CALL_WITHOUT_PARENTHESES;
+    }
+}

src/ValueObject/PhpVersionFeature.php

@@ -684,6 +684,12 @@ final class PhpVersionFeature
      */
     public const DEPRECATE_IMPLICIT_NULLABLE_PARAM_TYPE = PhpVersion::PHP_84;
 
+    /**
+     * @see https://wiki.php.net/rfc/new_without_parentheses
+     * @var int
+     */
+    public const NEW_METHOD_CALL_WITHOUT_PARENTHESES = PhpVersion::PHP_84;
+
     /**
      * @see https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum
      * @var int