[ci-review] Rector Rectify

Author: actions-user

rules/CodeQuality/Rector/BooleanAnd/RepeatedAndNotEqualToNotInArrayRector.php

@@ -8,8 +8,6 @@
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
-use PhpParser\Node\Expr\BinaryOp\Equal;
-use PhpParser\Node\Expr\BinaryOp\Identical;
 use PhpParser\Node\Expr\BinaryOp\NotEqual;
 use PhpParser\Node\Expr\BinaryOp\NotIdentical;
 use PhpParser\Node\Expr\BooleanNot;
@@ -181,19 +179,15 @@ private function matchComparedAndDesiredValues(BooleanAnd $booleanAnd): ?array
         return array_reverse($comparedExprAndValueExprs);
     }
 
-    private function isStrictComparison(BooleanAnd $node): bool
+    private function isStrictComparison(BooleanAnd $booleanAnd): bool
     {
-        $notIenticals = $this->betterNodeFinder->findInstanceOf($node, NotIdentical::class);
-        $notEquals = $this->betterNodeFinder->findInstanceOf($node, NotEqual::class);
+        $notIenticals = $this->betterNodeFinder->findInstanceOf($booleanAnd, NotIdentical::class);
+        $notEquals = $this->betterNodeFinder->findInstanceOf($booleanAnd, NotEqual::class);
 
         if ($notIenticals !== []) {
-            if ($notEquals !== []) {
-                // mix identical and equals, keep as is
-                // @see https://3v4l.org/24cFl
-                return false;
-            }
-
-            return true;
+            // mix identical and equals, keep as is
+            // @see https://3v4l.org/24cFl
+            return $notEquals === [];
         }
 
         return false;

rules/Privatization/NodeManipulator/VisibilityManipulator.php

@@ -207,7 +207,7 @@ private function replaceVisibilityFlag(ClassMethod | Property | ClassConst | Par
             $this->makeNonStatic($node);
         }
 
-        if ($visibility !== Visibility::STATIC && $visibility !== Visibility::ABSTRACT && $visibility !== Visibility::FINAL) {
+        if (!in_array($visibility, [Visibility::STATIC, Visibility::ABSTRACT, Visibility::FINAL], true)) {
             $this->removeVisibility($node);
         }
 

src/ValueObject/Error/SystemError.php

@@ -83,7 +83,7 @@ public function getRectorClass(): ?string
     public function getRectorShortClass(): ?string
     {
         $rectorClass = $this->rectorClass;
-        if ($rectorClass !== null && $rectorClass !== '' && $rectorClass !== '0') {
+        if (!in_array($rectorClass, [null, '', '0'], true)) {
             return (string) Strings::after($rectorClass, '\\', -1);
         }