[CodeQuality] Properly handle Goto_ on ExplicitReturnNullRector take 2 (#7019)

* [CodeQuality] More use case of Goto_ with Label_ on end statement

* [CodeQuality] Properly handle Goto_ on ExplicitReturnNullRector take 2

* eol

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

Author: samsonasik

rules-tests/CodeQuality/Rector/ClassMethod/ExplicitReturnNullRector/Fixture/break_on_switch.php.inc

@@ -0,0 +1,42 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\ExplicitReturnNullRector\Fixture;
+
+final class BreakOnSwitch
+{
+    public function run($var) {
+        switch($var) {
+            case 'test':
+                goto result;
+            default:
+                return false;
+        }
+
+        result:
+            echo 'test';
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\ExplicitReturnNullRector\Fixture;
+
+final class BreakOnSwitch
+{
+    public function run($var) {
+        switch($var) {
+            case 'test':
+                goto result;
+            default:
+                return false;
+        }
+
+        result:
+            echo 'test';
+            return null;
+    }
+}
+
+?>

rules/TypeDeclaration/TypeInferer/SilentVoidResolver.php

@@ -26,6 +26,7 @@
 use PhpParser\Node\Stmt\Function_;
 use PhpParser\Node\Stmt\Goto_;
 use PhpParser\Node\Stmt\If_;
+use PhpParser\Node\Stmt\Label;
 use PhpParser\Node\Stmt\Return_;
 use PhpParser\Node\Stmt\Switch_;
 use PhpParser\Node\Stmt\TryCatch;
@@ -83,6 +84,14 @@ public function hasSilentVoid(FunctionLike $functionLike): bool
      */
     private function hasStmtsAlwaysReturnOrExit(array $stmts): bool
     {
+        // early label check
+        // as label can be defined later after goto
+        foreach ($stmts as $key => $stmt) {
+            if ($stmt instanceof Label && isset($stmts[$key + 1])) {
+                return $this->hasStmtsAlwaysReturnOrExit(array_slice($stmts, $key + 1));
+            }
+        }
+
         foreach ($stmts as $stmt) {
             if ($this->neverFuncCallAnalyzer->isWithNeverTypeExpr($stmt)) {
                 return true;