fix skip use on Symfony\Component\DependencyInjection\Loader\Configurator\ServiceConfigurator

Author: samsonasik

rules-tests/Php81/Rector/Array_/ArrayToFirstClassCallableRector/Fixture/skip_as_service_factory_arg.php.inc

@@ -73,7 +73,7 @@ public function match(
         }
 
         if ($array->getAttribute(AttributeKey::IS_ARG_VALUE) === true && (bool) $array->getAttribute(
-            AttributeKey::IS_ARG_VALUE_CALLABLE
+            AttributeKey::IS_ARG_VALUE_FACTORY_SERVICECONFIGURATOR
         ) === false) {
             return null;
         }

src/NodeCollector/NodeAnalyzer/ArrayCallableMethodMatcher.php

@@ -167,5 +167,5 @@ final class AttributeKey
 
     public const string IS_IN_TRY_BLOCK = 'is_in_try_block';
 
-    public const string IS_ARG_VALUE_CALLABLE = 'is_arg_value_callable';
+    public const string IS_ARG_VALUE_FACTORY_SERVICECONFIGURATOR = 'is_arg_value_factory_serviceconfigurator';
 }

src/NodeTypeResolver/Node/AttributeKey.php

@@ -103,7 +103,15 @@ public function enterNode(Node $node): ?Node
 
         if ($node instanceof CallLike && ! $node->isFirstClassCallable()) {
             $functionReflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($node);
-            if (! $functionReflection instanceof FunctionReflection && ! $functionReflection instanceof MethodReflection) {
+            if (! $functionReflection instanceof MethodReflection) {
+                return null;
+            }
+
+            if ($functionReflection->getDeclaringClass()->getName() !== 'Symfony\Component\DependencyInjection\Loader\Configurator\ServiceConfigurator') {
+                return null;
+            }
+
+            if ($functionReflection->getName() !== 'factory') {
                 return null;
             }
 
@@ -120,26 +128,21 @@ public function enterNode(Node $node): ?Node
 
             $args = $node->getArgs();
             foreach ($parametersAcceptor->getParameters() as $key => $parameterReflection) {
-                // also process maybe callable
-                if ($parameterReflection->getType()->isCallable()->no()) {
-                    continue;
-                }
-
-                if ($parameterReflection->getType() instanceof ArrayType) {
+                if ($parameterReflection->getName() !== 'factory') {
                     continue;
                 }
 
                 // based on name
                 foreach ($args as $arg) {
-                    if ($arg->name instanceof Identifier && $parameterReflection->getName() === $arg->name->toString()) {
-                        $arg->value->setAttribute(AttributeKey::IS_ARG_VALUE_CALLABLE, true);
+                    if ($arg->name instanceof Identifier && 'factory' === $arg->name->toString()) {
+                        $arg->value->setAttribute(AttributeKey::IS_ARG_VALUE_FACTORY_SERVICECONFIGURATOR, true);
                         continue 2;
                     }
                 }
 
                 // based on key
                 if (isset($args[$key])) {
-                    $args[$key]->value->setAttribute(AttributeKey::IS_ARG_VALUE_CALLABLE, true);
+                    $args[$key]->value->setAttribute(AttributeKey::IS_ARG_VALUE_FACTORY_SERVICECONFIGURATOR, true);
                 }
             }
         }

src/PhpParser/NodeVisitor/ContextNodeVisitor.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+use Symfony\Component\DependencyInjection\Loader\Configurator\ReferenceConfigurator;
+use Symfony\Component\ExpressionLanguage\Expression;
+
+if (class_exists('Symfony\\Component\\DependencyInjection\\Loader\\Configurator\\ContainerConfigurator')) {
+    return;
+}
+
+class ContainerConfigurator
+{
+    public function services(): ServiceConfigurator
+    {
+        return new ServiceConfigurator();
+    }
+}

stubs/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+use Symfony\Component\DependencyInjection\Loader\Configurator\ReferenceConfigurator;
+use Symfony\Component\ExpressionLanguage\Expression;
+
+if (class_exists('Symfony\\Component\\DependencyInjection\\Loader\\Configurator\\ServiceConfigurator')) {
+    return;
+}
+
+class ServiceConfigurator
+{
+    function factory(string|array|ReferenceConfigurator|Expression $factory): static
+    {
+        return $this;
+    }
+}