Skip to content

Commit 12f7b60

Browse files
committed
verify string equal first before substr with negative -1
1 parent 9a95b6b commit 12f7b60

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,13 @@ public function shouldSkip(File $file, FullyQualifiedObjectType $fullyQualifiedO
4646
$namespace = strtolower((string) $namespace);
4747

4848
$shortNameLowered = $fullyQualifiedObjectType->getShortNameLowered();
49-
50-
$subClassName = substr(
51-
$fullyQualifiedObjectType->getClassName(),
52-
0,
53-
-strlen($fullyQualifiedObjectType->getShortName()) - 1
54-
);
49+
$subClassName = $fullyQualifiedObjectType->getClassName() === $fullyQualifiedObjectType->getShortName()
50+
? ''
51+
: substr(
52+
$fullyQualifiedObjectType->getClassName(),
53+
0,
54+
-strlen($fullyQualifiedObjectType->getShortName()) - 1
55+
);
5556

5657
$fullyQualifiedObjectTypeNamespace = strtolower($subClassName);
5758

0 commit comments

Comments
 (0)