[CodeQuality] Only allow from final class or constant is marked final on VariableConstFetchToClassConstFetchRector (#7904)

Author: samsonasik

…stFetchRector/Fixture/some_class.php.inc …xture/allow_final_class_constant.php.incrules-tests/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector/Fixture/some_class.php.inc renamed to rules-tests/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector/Fixture/allow_final_class_constant.php.inc rules-tests/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector/Fixture/some_class.php.inc renamed to rules-tests/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector/Fixture/allow_final_class_constant.php.inc

@@ -4,13 +4,13 @@ declare(strict_types=1);
 
 namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Fixture;
 
-use Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ClassWithConstants;
+use Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ClassWithFinalConstant;
 
-final class SomeClass
+final class AllowFinalClassConstant
 {
-    public function run(ClassWithConstants $classWithConstants)
+    public function run(ClassWithFinalConstant $classWithFinalConstant)
     {
-        return $classWithConstants::NAME;
+        return $classWithFinalConstant::NAME;
     }
 }
 
@@ -22,13 +22,13 @@ declare(strict_types=1);
 
 namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Fixture;
 
-use Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ClassWithConstants;
+use Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ClassWithFinalConstant;
 
-final class SomeClass
+final class AllowFinalClassConstant
 {
-    public function run(ClassWithConstants $classWithConstants)
+    public function run(ClassWithFinalConstant $classWithFinalConstant)
     {
-        return \Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ClassWithConstants::NAME;
+        return \Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ClassWithFinalConstant::NAME;
     }
 }
 

rules-tests/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector/Fixture/skip_class_constant_from_non_final_class.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ClassWithConstants;
+
+final class SkipClassConstantFromNonFinalClass
+{
+    public function run(ClassWithConstants $classWithConstants)
+    {
+        return $classWithConstants::NAME;
+    }
+}

rules-tests/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector/Source/ClassWithFinalConstant.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source;
+
+class ClassWithFinalConstant
+{
+    public final const NAME = 'SomeName';
+}

rules/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector.php

@@ -9,6 +9,7 @@
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name\FullyQualified;
+use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\ObjectType;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -19,13 +20,22 @@
  */
 final class VariableConstFetchToClassConstFetchRector extends AbstractRector
 {
+    public function __construct(
+        private readonly ReflectionProvider $reflectionProvider
+    ) {
+    }
+
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
-            'Change variable class constant fetch to direct class constant fetch',
+            'Change variable class constant fetch to direct class constant fetch when class or constant target is final',
             [
                 new CodeSample(
                     <<<'CODE_SAMPLE'
+final class AnotherClass
+{
+}
+
 class SomeClass
 {
     public function run(AnotherClass $anotherClass)
@@ -36,6 +46,10 @@ public function run(AnotherClass $anotherClass)
 CODE_SAMPLE
                     ,
                     <<<'CODE_SAMPLE'
+final class AnotherClass
+{
+}
+
 class SomeClass
 {
     public function run(AnotherClass $anotherClass)
@@ -84,6 +98,22 @@ public function refactor(Node $node): ?ClassConstFetch
             return null;
         }
 
+        if (! $this->reflectionProvider->hasClass($classObjectType->getClassName())) {
+            return null;
+        }
+
+        $classReflection = $this->reflectionProvider->getClass($classObjectType->getClassName());
+        if (! $classReflection->isFinalByKeyword()) {
+            if (! $classReflection->hasConstant($constantName)) {
+                return null;
+            }
+
+            $constant = $classReflection->getConstant($constantName);
+            if (! $constant->isFinal()) {
+                return null;
+            }
+        }
+
         $node->class = new FullyQualified($classObjectType->getClassName());
 
         return $node;