[Diffs] Handle --no-diffs usage to show file have been changed if any with --dry-run + --no-diffs (#7619)

* [Diffs] Handle --no-diffs usage to show file have been changed if any with --dry-run + --no-diffs

* fix phpstan

* Fix total changed

* clean up

* Fix phpstan

* Add e2e test for show files changed without diff

* Add e2e test for show files changed without diff

* eol

Author: samsonasik

.github/workflows/e2e_with_no_diffs.yaml

@@ -0,0 +1,49 @@
+# This workflow runs system tests: Use the Rector application from the source
+# checkout to process "fixture" projects in e2e/ directory
+# to see if those can be processed successfully
+name: End to End tests with no diffs
+
+on:
+    pull_request:
+        branches:
+            - main
+    push:
+        branches:
+            - main
+
+env:
+    # see https://github.com/composer/composer/issues/9368#issuecomment-718112361
+    COMPOSER_ROOT_VERSION: "dev-main"
+
+jobs:
+    end_to_end:
+        runs-on: ubuntu-latest
+        timeout-minutes: 3
+        strategy:
+            fail-fast: false
+            matrix:
+                php_version: ['8.2']
+                directory:
+                    - 'e2e/applied-rule-removed-node-no-diffs'
+
+        name: End to end test - ${{ matrix.directory }}
+
+        steps:
+            -   uses: actions/checkout@v4
+
+            -   uses: shivammathur/setup-php@v2
+                with:
+                    php-version: ${{ matrix.php_version }}
+                    coverage: none
+
+            # run in root rector-src
+            -   run: composer install --ansi
+
+            # run in e2e subdir
+            -
+                run: composer install --ansi
+                working-directory: ${{ matrix.directory }}
+
+            # run e2e test
+            -   run: php ../e2eTestRunner.php --no-diffs
+                working-directory: ${{ matrix.directory }}

e2e/applied-rule-removed-node-no-diffs/.gitignore

@@ -0,0 +1 @@
+/vendor

e2e/applied-rule-removed-node-no-diffs/composer.json

@@ -0,0 +1,7 @@
+{
+    "require": {
+        "php": "^8.1"
+    },
+    "minimum-stability": "dev",
+    "prefer-stable": true
+}

e2e/applied-rule-removed-node-no-diffs/expected-output.diff

@@ -0,0 +1 @@
+[OK] 2 files would have been changed (dry-run) by Rector

e2e/applied-rule-removed-node-no-diffs/rector.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector;
+use Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->paths([
+        __DIR__ . '/src',
+    ]);
+
+    $rectorConfig->rule(RemoveEmptyClassMethodRector::class);
+    $rectorConfig->rule(RemoveAlwaysTrueIfConditionRector::class);
+};

e2e/applied-rule-removed-node-no-diffs/src/AlwaysTrue.php

@@ -0,0 +1,12 @@
+<?php
+
+final class AlwaysTrue
+{
+    public function run()
+    {
+        if (1 === 1) {
+        }
+
+        return 'no';
+    }
+}

e2e/applied-rule-removed-node-no-diffs/src/DeadConstructor.php

@@ -0,0 +1,8 @@
+<?php
+
+final class DeadConstructor
+{
+    public function __construct()
+    {
+    }
+}

e2e/e2eTestRunner.php

@@ -32,6 +32,10 @@
     $e2eCommand .= ' -a ' . $argv[2];
 }
 
+if (isset($argv[1]) && $argv[1] === '--no-diffs') {
+    $e2eCommand .= ' --no-diffs';
+}
+
 $cliOptions = 'cli-options.txt';
 if (file_exists($cliOptions)) {
     $e2eCommand .= ' ' . trim((string) file_get_contents($cliOptions));

src/Application/ApplicationFileProcessor.php

@@ -61,7 +61,7 @@ public function run(Configuration $configuration, InputInterface $input): Proces
 
         // no files found
         if ($filePaths === []) {
-            return new ProcessResult([], []);
+            return new ProcessResult([], [], 0);
         }
 
         $this->missConfigurationReporter->reportVendorInPaths($filePaths);
@@ -124,6 +124,7 @@ public function processFiles(
         /** @var FileDiff[] $fileDiffs */
         $fileDiffs = [];
 
+        $totalChanged = 0;
         foreach ($filePaths as $filePath) {
             if ($preFileCallback !== null) {
                 $preFileCallback($filePath);
@@ -148,6 +149,10 @@ public function processFiles(
                 if (is_callable($postFileCallback)) {
                     $postFileCallback(1);
                 }
+
+                if ($fileProcessResult->hasChanged()) {
+                    ++$totalChanged;
+                }
             } catch (Throwable $throwable) {
                 $this->changedFilesDetector->invalidateFile($filePath);
 
@@ -159,7 +164,7 @@ public function processFiles(
             }
         }
 
-        return new ProcessResult($systemErrors, $fileDiffs);
+        return new ProcessResult($systemErrors, $fileDiffs, $totalChanged);
     }
 
     private function processFile(File $file, Configuration $configuration): FileProcessResult

src/Application/FileProcessor.php

@@ -48,7 +48,7 @@ public function processFile(File $file, Configuration $configuration): FileProce
         $parsingSystemError = $this->parseFileAndDecorateNodes($file);
         if ($parsingSystemError instanceof SystemError) {
             // we cannot process this file as the parsing and type resolving itself went wrong
-            return new FileProcessResult([$parsingSystemError], null);
+            return new FileProcessResult([$parsingSystemError], null, false);
         }
 
         $fileHasChanged = false;
@@ -100,7 +100,7 @@ public function processFile(File $file, Configuration $configuration): FileProce
             $file->setFileDiff($currentFileDiff);
         }
 
-        return new FileProcessResult([], $file->getFileDiff());
+        return new FileProcessResult([], $file->getFileDiff(), $file->hasChanged());
     }
 
     private function parseFileAndDecorateNodes(File $file): ?SystemError