Fix

Author: samsonasik

rules-tests/Php85/Rector/ShellExec/ShellExecFunctionCallOverBackticksRector/Fixture/skip_empty_backticks.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Php85\Rector\ShellExec\ShellExecFunctionCallOverBackticksRector\Fixture;
+
+class SkipEmptyBackticks
+{
+    public function run()
+    {
+        ``;
+    }
+}

rules-tests/Php85/Rector/ShellExec/ShellExecFunctionCallOverBackticksRector/Fixture/with_variable.php.inc

@@ -29,8 +29,8 @@ class WithVariable
         $dir = __DIR__;
         $var = 'example';
 
-        $output = shell_exec("ls $dir");
-        $output2 = shell_exec("echo \"value: $var\"");
+        $output = shell_exec('ls ' . $dir);
+        $output2 = shell_exec('echo "value: ' . $var . '"');
         echo "<pre>$output</pre>";
         echo "<pre>$output2</pre>";
     }

rules/Php85/Rector/ShellExec/ShellExecFunctionCallOverBackticksRector.php

@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Arg;
+use PhpParser\Node\Expr\BinaryOp\Concat;
 use PhpParser\Node\Expr\ShellExec;
 use PhpParser\Node\InterpolatedStringPart;
 use PhpParser\Node\Scalar\String_;
@@ -49,17 +50,38 @@ public function getNodeTypes(): array
     /**
      * @param ShellExec $node
      */
-    public function refactor(Node $node): Node
+    public function refactor(Node $node): ?Node
     {
-        $args = array_map(function (Node $node): Node {
-            if ($node instanceof InterpolatedStringPart) {
-                return new Arg(new String_($node->value));
+        if ($node->parts === []) {
+            return null;
+        }
+
+        $exprs = [];
+        foreach ($node->parts as $part) {
+            if ($part instanceof InterpolatedStringPart) {
+                // keep as single-quoted string literal and escape single quotes inside
+                $escaped = str_replace("'", "\\'", $part->value);
+                $exprs[] = new String_($escaped);
+                continue;
             }
 
-            return new Arg($node);
-        }, $node->parts);
+            // other parts are Expr (variables, function calls, etc.)
+            // keep them as-is so they are concatenated
+            $exprs[] = $part;
+        }
+
+        // reduce to single concatenated expression
+        if (count($exprs) === 1) {
+            $argExpr = $exprs[0];
+        } else {
+            $argExpr = array_shift($exprs);
+            foreach ($exprs as $expr) {
+                $argExpr = new Concat($argExpr, $expr);
+            }
+        }
 
-        return $this->nodeFactory->createFuncCall('shell_exec', $args);
+        // create single Arg and call shell_exec
+        return $this->nodeFactory->createFuncCall('shell_exec', [new Arg($argExpr)]);
     }
 
     public function provideMinPhpVersion(): int