fix phpstan

Author: samsonasik

rules/Php73/Rector/FuncCall/JsonThrowOnErrorRector.php

@@ -29,8 +29,6 @@ final class JsonThrowOnErrorRector extends AbstractRector implements MinPhpVersi
 {
     private const array FLAGS = ['JSON_THROW_ON_ERROR'];
 
-    private bool $hasChanged = false;
-
     public function __construct(
         private readonly ValueResolver $valueResolver,
         private readonly BetterNodeFinder $betterNodeFinder
@@ -77,9 +75,9 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $this->hasChanged = false;
+        $hasChanged = false;
 
-        $this->traverseNodesWithCallable($node, function (Node $currentNode): ?FuncCall {
+        $this->traverseNodesWithCallable($node, function (Node $currentNode) use (&$hasChanged): ?FuncCall {
             if (! $currentNode instanceof FuncCall) {
                 return null;
             }
@@ -89,17 +87,17 @@ public function refactor(Node $node): ?Node
             }
 
             if ($this->isName($currentNode, 'json_encode')) {
-                return $this->processJsonEncode($currentNode);
+                return $this->processJsonEncode($currentNode, $hasChanged);
             }
 
             if ($this->isName($currentNode, 'json_decode')) {
-                return $this->processJsonDecode($currentNode);
+                return $this->processJsonDecode($currentNode, $hasChanged);
             }
 
             return null;
         });
 
-        if ($this->hasChanged) {
+        if ($hasChanged) {
             return $node;
         }
 
@@ -134,7 +132,7 @@ private function shouldSkipFuncCall(FuncCall $funcCall): bool
         return $this->isFirstValueStringOrArray($funcCall);
     }
 
-    private function processJsonEncode(FuncCall $funcCall): FuncCall
+    private function processJsonEncode(FuncCall $funcCall, bool &$hasChanged): FuncCall
     {
         $flags = [];
         if (isset($funcCall->args[1])) {
@@ -145,14 +143,14 @@ private function processJsonEncode(FuncCall $funcCall): FuncCall
 
         $newArg = $this->getArgWithFlags($flags);
         if ($newArg instanceof Arg) {
-            $this->hasChanged = true;
+            $hasChanged = true;
             $funcCall->args[1] = $newArg;
         }
 
         return $funcCall;
     }
 
-    private function processJsonDecode(FuncCall $funcCall): FuncCall
+    private function processJsonDecode(FuncCall $funcCall, bool &$hasChanged): FuncCall
     {
         $flags = [];
         if (isset($funcCall->args[3])) {
@@ -172,7 +170,7 @@ private function processJsonDecode(FuncCall $funcCall): FuncCall
 
         $newArg = $this->getArgWithFlags($flags);
         if ($newArg instanceof Arg) {
-            $this->hasChanged = true;
+            $hasChanged = true;
             $funcCall->args[3] = $newArg;
         }
 

src/ChangesReporting/Output/GitlabOutputFormatter.php

@@ -30,7 +30,7 @@
     private const string ERROR_SEVERITY_MINOR = 'minor';
 
     public function __construct(
-        private Filehasher $filehasher,
+        private FileHasher $filehasher,
     ) {
     }