init test

Author: TomasVotruba

src/PhpParser/NodeTraverser/AbstractImmutableNodeTraverser.php

@@ -112,10 +112,8 @@ protected function traverseNode(Node $node): void
                         $node->{$name} = $return;
 
                         if ($originalSubNodeClass !== $subNode::class) {
-                            // stop traversing as node has changed its class and visitors do not work
-                            $traverseChildren = false;
-                            $this->stopTraversal = true;
-                            break 2;
+                            // stop traversing as node type changed and visitors won't work
+                            return;
                         }
 
                     } elseif ($return === NodeVisitor::DONT_TRAVERSE_CHILDREN) {
@@ -196,9 +194,8 @@ protected function traverseArray(array $nodes): array
                         $nodes[$i] = $node = $return;
 
                         if ($originalNodeNodeClass !== $return::class) {
-                            // stop traversing as node has changed its class and visitors do not work
-                            $this->stopTraversal = true;
-                            break 2;
+                            // stop traversing as node type changed and visitors won't work
+                            return $nodes;
                         }
                     } elseif (\is_array($return)) {
                         $doNodes[] = [$i, $return];

tests/PhpParser/NodeTraverser/StopTraverseOnTypeChange/Class_/RuleChangingClassToTraitRector.php

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\Tests\PhpParser\NodeTraverser\StopTraverseOnTypeChange\Class_;
+
+use PhpParser\Node;
+use Rector\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+final class RuleChangingClassToTraitRector extends AbstractRector
+{
+
+    public function getRuleDefinition(): RuleDefinition
+    {
+    }
+
+    public function getNodeTypes(): array
+    {
+        return [Node\Stmt\Class_::class];
+    }
+
+    /**
+     * @param Node\Stmt\Class_ $node
+     * @return Node\Stmt\Trait_
+     */
+    public function refactor(Node $node)
+    {
+        return new Node\Stmt\Trait_('SomeTrait');
+    }
+}

tests/PhpParser/NodeTraverser/StopTraverseOnTypeChange/Class_/RuleCheckingClassRector.php

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\Tests\PhpParser\NodeTraverser\StopTraverseOnTypeChange\Class_;
+
+use PhpParser\Node;
+use PhpParser\Node\Stmt\Class_;
+use Rector\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
+
+final class RuleCheckingClassRector extends AbstractRector
+{
+
+    public function getRuleDefinition(): RuleDefinition
+    {
+    }
+
+    public function getNodeTypes(): array
+    {
+        return [Class_::class];
+    }
+
+    /**
+     * @param Class_ $node
+     * @return Class_
+     */
+    public function refactor(Node $node)
+    {
+        Assert::isInstanceOf($node, Class_::class);
+
+        return $node;
+    }
+}

tests/PhpParser/NodeTraverser/StopTraverseOnTypeChange/StopTraverseOnTypeChangeTest.php

@@ -0,0 +1,41 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\PhpParser\NodeTraverser\StopTraverseOnTypeChange;
+
+use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\Trait_;
+use Rector\Application\Provider\CurrentFileProvider;
+use Rector\PhpParser\NodeTraverser\RectorNodeTraverser;
+use Rector\Testing\PHPUnit\AbstractLazyTestCase;
+use Rector\Tests\PhpParser\NodeTraverser\StopTraverseOnTypeChange\Class_\RuleChangingClassToTraitRector;
+use Rector\Tests\PhpParser\NodeTraverser\StopTraverseOnTypeChange\Class_\RuleCheckingClassRector;
+
+final class StopTraverseOnTypeChangeTest extends AbstractLazyTestCase
+{
+    private RectorNodeTraverser $rectorNodeTraverser;
+
+    protected function setUp(): void
+    {
+        $this->rectorNodeTraverser = $this->make(RectorNodeTraverser::class);
+
+        $this->rectorNodeTraverser->refreshPhpRectors([
+            $this->make(RuleChangingClassToTraitRector::class),
+            $this->make(RuleCheckingClassRector::class)
+        ]);
+
+        $currentFileProvider = $this->make(CurrentFileProvider::class);
+
+        // @todo
+        // $currentFileProvider->setFile();
+    }
+
+    public function testGetVisitorsForNodeWhenNoVisitorsAvailable(): void
+    {
+        $class = new Class_('test');
+
+        $changedNodes = $this->rectorNodeTraverser->traverse([$class]);
+        $this->assertContainsOnlyInstancesOf(Trait_::class, $changedNodes);
+    }
+}