restore fixture

Author: TomasVotruba

rules-tests/Php70/Rector/ClassMethod/Php4ConstructorRector/Fixture/method_call_parent.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+class SomeParentA
+{
+    public function SomeParentA()
+    {
+    }
+}
+
+final class SomeChildB extends SomeParentA
+{
+    public function SomeChildB() {
+        $this->SomeParentA();
+    }
+}
+
+?>
+-----
+<?php
+
+class SomeParentA
+{
+    public function __construct()
+    {
+    }
+}
+
+final class SomeChildB extends SomeParentA
+{
+    public function __construct() {
+        \SomeParentA::__construct();
+    }
+}
+
+?>

rules-tests/Php70/Rector/ClassMethod/Php4ConstructorRector/Fixture/parent_constructor_call.php.inc

@@ -16,7 +16,7 @@ final class SomeChildB extends ParentClass
 {
     public function __construct()
     {
-        parent::__construct();
+        \ParentClass::__construct();
     }
 }
 

rules/Php70/NodeAnalyzer/MethodCallNameAnalyzer.php

@@ -6,9 +6,11 @@
 
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\ClassMethod;
 
 final class MethodCallNameAnalyzer
 {
@@ -18,7 +20,7 @@ public function isLocalMethodCallNamed(Expr $expr, string $desiredMethodName): b
             return false;
         }
 
-        if (! $expr->var instanceof Expr\Variable) {
+        if (! $expr->var instanceof Variable) {
             return false;
         }
 
@@ -40,7 +42,7 @@ public function isParentMethodCall(Class_ $class, Expr $expr): bool
         }
 
         $parentClassName = $class->extends->toString();
-        if ($class->getMethod($parentClassName)) {
+        if ($class->getMethod($parentClassName) instanceof ClassMethod) {
             return false;
         }
 

rules/Php70/Rector/ClassMethod/Php4ConstructorRector.php

@@ -9,6 +9,7 @@
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
+use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Expression;
@@ -137,7 +138,10 @@ public function refactor(Node $node): Class_|null
                     /** @var MethodCall $expr */
                     $expr = $classMethodStmt->expr;
 
-                    $classMethodStmt->expr = new StaticCall(new Name(ObjectReference::PARENT), new Identifier(
+                    /** @var string $parentClassName */
+                    $parentClassName = $this->getParentClassName($node);
+
+                    $classMethodStmt->expr = new StaticCall(new FullyQualified($parentClassName), new Identifier(
                         MethodName::CONSTRUCT
                     ), $expr->args);
                 }
@@ -194,4 +198,13 @@ private function processParentPhp4ConstructCall(StaticCall $staticCall, Scope $s
 
         $staticCall->name = new Identifier(MethodName::CONSTRUCT);
     }
+
+    private function getParentClassName(Class_ $class): ?string
+    {
+        if (! $class->extends instanceof \PhpParser\Node) {
+            return null;
+        }
+
+        return $class->extends->toString();
+    }
 }