remove replace null, as not legal refactor() value

Author: TomasVotruba

src/PhpParser/NodeTraverser/RectorNodeTraverser.php

@@ -36,13 +36,10 @@ final class RectorNodeTraverser implements NodeTraverserInterface
     private array $visitorsPerNodeClass = [];
 
     /**
-     * @var list<NodeVisitor> Visitors
+     * @var RectorInterface[]
      */
     private array $visitors = [];
 
-    /**
-     * @var bool Whether traversal should be stopped
-     */
     private bool $stopTraversal;
 
     /**
@@ -55,17 +52,6 @@ public function __construct(
     ) {
     }
 
-    //    /**
-    //     * @param Stmt[] $rectors
-    //     * @return Stmt[]
-    //     */
-    //    public function traverse(array $nodes): array
-    //    {
-    //        $this->prepareNodeVisitors();
-    //
-    //        return parent::traverse($nodes);
-    //    }
-
     /**
      * @param RectorInterface[] $rectors
      * @api used in tests to update the active rules
@@ -117,18 +103,6 @@ public function getVisitorsForNode(Node $node): array
     }
 
     /**
-//     * Create a traverser with the given visitors.
-//     *
-//     * @param NodeVisitor ...$visitor Node visitors
-//     */
-    //    public function __construct(NodeVisitor ...$visitors)
-    //    {
-    //        $this->visitors = $visitors;
-    //    }
-
-    /**
-     * Adds a visitor.
-     *
      * @deprecated @todo remove completely, even in tests to avoid mutable state
      */
     public function addVisitor(NodeVisitor $visitor): void
@@ -142,11 +116,8 @@ public function removeVisitor(NodeVisitor $visitor): void
     }
 
     /**
-     * Traverses an array of nodes using the registered visitors.
-     *
-     * @param Node[] $nodes Array of nodes
-     *
-     * @return Node[] Traversed array of nodes
+     * @param Node[] $nodes
+     * @return Node[]
      */
     public function traverse(array $nodes): array
     {
@@ -171,7 +142,8 @@ public function traverse(array $nodes): array
     }
 
     /**
-     * This must happen after $this->configuration is set after ProcessCommand::execute() is run, otherwise we get default false positives.
+     * This must happen after $this->configuration is set after ProcessCommand::execute() is run,
+     * otherwise we get default false positives.
      *
      * This should be removed after https://github.com/rectorphp/rector/issues/5584 is resolved
      */
@@ -181,10 +153,7 @@ private function prepareNodeVisitors(): void
             return;
         }
 
-        // filer out by version
         $this->visitors = $this->phpVersionedFilter->filter($this->rectors);
-
-        // filter by configuration
         $this->visitors = $this->configurationRuleFilter->filter($this->visitors);
 
         $this->areNodeVisitorsPrepared = true;
@@ -233,9 +202,6 @@ private function traverseNode(Node $node): void
                     } elseif ($return === NodeVisitor::STOP_TRAVERSAL) {
                         $this->stopTraversal = true;
                         break 2;
-                    } elseif ($return === NodeVisitor::REPLACE_WITH_NULL) {
-                        $node->{$name} = null;
-                        continue 2;
                     } else {
                         throw new LogicException('enterNode() returned invalid value of type ' . gettype($return));
                     }
@@ -253,21 +219,25 @@ private function traverseNode(Node $node): void
 
     /**
      * @param Node[] $nodes
-     * @return \PhpParser\Node[] Result of traversal (may be original array or changed one)
+     * @return Node[]
      */
     private function traverseArray(array $nodes): array
     {
         $doNodes = [];
         foreach ($nodes as $i => $node) {
             if (! $node instanceof Node) {
                 if (\is_array($node)) {
-                    throw new LogicException('Invalid node structure: Contains nested arrays');
+                    throw new LogicException(sprintf(
+                        'Invalid node "%s" structure: Contains nested arrays',
+                        $node::class,
+                    ));
                 }
 
                 continue;
             }
 
             $traverseChildren = true;
+
             $currentNodeVisitors = $this->getVisitorsForNode($node);
 
             foreach ($currentNodeVisitors as $currentNodeVisitor) {
@@ -296,10 +266,6 @@ private function traverseArray(array $nodes): array
                     } elseif ($return === NodeVisitor::STOP_TRAVERSAL) {
                         $this->stopTraversal = true;
                         break 2;
-                    } elseif ($return === NodeVisitor::REPLACE_WITH_NULL) {
-                        throw new LogicException(
-                            'REPLACE_WITH_NULL can not be used if the parent structure is an array'
-                        );
                     } else {
                         throw new LogicException('enterNode() returned invalid value of type ' . gettype($return));
                     }