fix

Author: samsonasik

rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/skip_equal_numeric_string.php.inc

@@ -10,6 +10,10 @@ final class SkipIdenticalNumericString
             return 'yes';
         }
 
+        if ('1' == $this->getValue()) {
+            return 'yes 2';
+        }
+
         return 'no';
     }
 

rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php

@@ -12,6 +12,7 @@
 use PhpParser\Node\Expr\BinaryOp\NotIdentical;
 use PHPStan\Type\BooleanType;
 use PHPStan\Type\MixedType;
+use PHPStan\Type\Type;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -73,6 +74,10 @@ public function refactor(Node $node): ?Node
         $leftStaticType = $this->nodeTypeResolver->getNativeType($node->left);
         $rightStaticType = $this->nodeTypeResolver->getNativeType($node->right);
 
+        if ($this->shouldSkipCompareNumericString($leftStaticType, $rightStaticType)) {
+            return null;
+        }
+
         // objects can be different by content
         if (! $leftStaticType->isObject()->no() || ! $rightStaticType->isObject()->no()) {
             return null;
@@ -96,6 +101,15 @@ public function refactor(Node $node): ?Node
         return $this->processIdenticalOrNotIdentical($node);
     }
 
+    private function shouldSkipCompareNumericString(Type $leftStaticType, Type $rightStaticType): bool
+    {
+        if ($leftStaticType->isString()->yes() && $rightStaticType->isNumericString()->yes()) {
+            return true;
+        }
+
+        return $rightStaticType->isString()->yes() && $leftStaticType->isNumericString()->yes();
+    }
+
     private function processIdenticalOrNotIdentical(Equal|NotEqual $node): Identical|NotIdentical
     {
         if ($node instanceof Equal) {