[TypeDeclaration] Skip integer index on string on AddArrowFunctionParamArrayWhereDimFetchRector (#7178)

* [TypeDeclaration] Skip integer index on string on AddArrowFunctionParamArrayWhereDimFetchRector

* [TypeDeclaration] Skip integer index on string on AddArrowFunctionParamArrayWhereDimFetchRector

* [TypeDeclaration] Skip integer index on string on AddArrowFunctionParamArrayWhereDimFetchRector

Author: samsonasik

rules-tests/TypeDeclaration/Rector/FuncCall/AddArrowFunctionParamArrayWhereDimFetchRector/Fixture/skip_integer_index_on_string.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\FuncCall\AddArrowFunctionParamArrayWhereDimFetchRector\Fixture;
+
+final class SkipIntegerIndexOnString
+{
+    public function run()
+    {
+        $username = 'john.doe';
+
+        $initials = implode(
+            '',
+            array_map(
+                static fn ($name): string => strtoupper((string) $name[0]),
+                explode('.', $username),
+            ),
+        );
+    }
+}

rules/TypeDeclaration/Rector/FuncCall/AddArrowFunctionParamArrayWhereDimFetchRector.php

@@ -146,6 +146,12 @@ private function resolveDimFetchVariableNames(Closure|ArrowFunction $closureExpr
 
         foreach ($arrayDimFetches as $arrayDimFetch) {
             if ($arrayDimFetch->var instanceof Variable) {
+                $type = $this->nodeTypeResolver->getNativeType($arrayDimFetch->var);
+
+                if ($type->isString()->yes()) {
+                    continue;
+                }
+
                 $usedDimFetchVariableNames[] = (string) $this->getName($arrayDimFetch->var);
             }
         }