Skip to content

Commit 3c481b6

Browse files
authored
[CodeQuality] Skip abstract class on CompleteDynamicPropertiesRector (#8182)
1 parent 51d6173 commit 3c481b6

2 files changed

Lines changed: 16 additions & 0 deletions

File tree

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<?php
2+
3+
namespace Rector\Tests\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector\Fixture;
4+
5+
abstract class SkipAbstractClass
6+
{
7+
public function set()
8+
{
9+
$this->value = 5;
10+
}
11+
}

rules/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,11 @@ private function shouldSkipClass(Class_ $class): bool
114114
return true;
115115
}
116116

117+
// abstract class property might be accessed from child class
118+
if ($class->isAbstract()) {
119+
return true;
120+
}
121+
117122
$className = (string) $this->getName($class);
118123
if (! $this->reflectionProvider->hasClass($className)) {
119124
return true;

0 commit comments

Comments
 (0)