[dead-code] Add RemoveFilterVarOnExactTypeRector (#6792)

* [dead-code] Add RemoveFilterVarOnExactTypeRector

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

Author: TomasVotruba

rules-tests/DeadCode/Rector/FuncCall/RemoveFilterVarOnExactTypeRector/Fixture/remove_filter_var_on_constnant_fetch.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\FuncCall\RemoveFilterVarOnExactTypeRector\Fixture;
+
+final class RemoveFilterVarOnConstantFetch
+{
+    private const NUMBER = 123;
+
+    public function run()
+    {
+        return filter_var(self::NUMBER, FILTER_VALIDATE_INT);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\FuncCall\RemoveFilterVarOnExactTypeRector\Fixture;
+
+final class RemoveFilterVarOnConstantFetch
+{
+    private const NUMBER = 123;
+
+    public function run()
+    {
+        return self::NUMBER;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/FuncCall/RemoveFilterVarOnExactTypeRector/Fixture/remove_filter_var_on_exact_type.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\FuncCall\RemoveFilterVarOnExactTypeRector\Fixture;
+
+class RemoveFilterVarOnExactType
+{
+    public function run(int $number)
+    {
+        return filter_var($number, FILTER_VALIDATE_INT);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\FuncCall\RemoveFilterVarOnExactTypeRector\Fixture;
+
+class RemoveFilterVarOnExactType
+{
+    public function run(int $number)
+    {
+        return $number;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/FuncCall/RemoveFilterVarOnExactTypeRector/Fixture/skip_different_filter_const.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\FuncCall\RemoveFilterVarOnExactTypeRector\Fixture;
+
+final class RemoveFilterVarOnConstantFetch
+{
+    public function run(int $value)
+    {
+        return filter_var($value, FILTER_VALIDATE_EMAIL);
+    }
+}

rules-tests/DeadCode/Rector/FuncCall/RemoveFilterVarOnExactTypeRector/Fixture/skip_third_arg.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\FuncCall\RemoveFilterVarOnExactTypeRector\Fixture;
+
+final class SkipValueToBeModified
+{
+    public function run(int $value)
+    {
+        $options = [
+            'options' => [
+                'min_range' => 10,
+            ],
+            'flags' => FILTER_FLAG_ALLOW_OCTAL,
+        ];
+
+        return filter_var($value, FILTER_VALIDATE_INT, $options);
+    }
+}

rules-tests/DeadCode/Rector/FuncCall/RemoveFilterVarOnExactTypeRector/Fixture/skip_value_to_be_modified.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\FuncCall\RemoveFilterVarOnExactTypeRector\Fixture;
+
+final class SkipValueToBeModified
+{
+    public function run()
+    {
+        return filter_var('0755', FILTER_VALIDATE_INT);
+    }
+}

rules-tests/DeadCode/Rector/FuncCall/RemoveFilterVarOnExactTypeRector/RemoveFilterVarOnExactTypeRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\FuncCall\RemoveFilterVarOnExactTypeRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class RemoveFilterVarOnExactTypeRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/DeadCode/Rector/FuncCall/RemoveFilterVarOnExactTypeRector/config/configured_rule.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\FuncCall\RemoveFilterVarOnExactTypeRector;
+
+return RectorConfig::configure()
+    ->withRules([RemoveFilterVarOnExactTypeRector::class]);

rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/config/configured_rule.php

@@ -9,13 +9,13 @@
 use Rector\Php80\ValueObject\AnnotationToAttribute;
 use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\Annotation\OpenApi\Annotation\NestedPastAnnotation;
 use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\Annotation\OpenApi\PastAnnotation;
+use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\Attribute\NewName1;
+use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\Attribute\NewName2;
 use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\Attribute\OpenApi\Attribute\NestedFutureAttribute;
 use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\Attribute\OpenApi\FutureAttribute;
+use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\Attribute\SameName;
 use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\GenericAnnotation;
 use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\GenericSingleImplicitAnnotation;
-use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\Attribute\NewName1;
-use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\Attribute\NewName2;
-use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\Attribute\SameName;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->ruleWithConfiguration(AnnotationToAttributeRector::class, [

rules/DeadCode/Rector/FuncCall/RemoveFilterVarOnExactTypeRector.php

@@ -0,0 +1,91 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\DeadCode\Rector\FuncCall;
+
+use PhpParser\Node\Expr\ConstFetch;
+use PhpParser\Node;
+use PhpParser\Node\Expr\FuncCall;
+use Rector\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+/**
+ * @see \Rector\Tests\DeadCode\Rector\FuncCall\RemoveFilterVarOnExactTypeRector\RemoveFilterVarOnExactTypeRectorTest
+ */
+final class RemoveFilterVarOnExactTypeRector extends AbstractRector
+{
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition(
+            'Removes filter_var() calls with exact type',
+            [
+                new CodeSample(
+                    <<<'CODE_SAMPLE'
+function (int $value) {
+    $result = filter_var($value, FILTER_VALIDATE_INT);
+}
+CODE_SAMPLE
+                    ,
+                    <<<'CODE_SAMPLE'
+function (int $value) {
+    $result = $value;
+}
+CODE_SAMPLE
+                ),
+            ]
+        );
+    }
+
+    public function getNodeTypes(): array
+    {
+        return [FuncCall::class];
+    }
+
+    /**
+     * @param FuncCall $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if ($node->isFirstClassCallable()) {
+            return null;
+        }
+
+        if (! $this->isName($node, 'filter_var')) {
+            return null;
+        }
+
+        // we need exact 2nd arg to assess value type
+        if (count($node->getArgs()) !== 2) {
+            return null;
+        }
+
+        $firstArgValue = $node->getArgs()[0]
+            ->value;
+        $secondArgValue = $node->getArgs()[1]
+            ->value;
+
+        if (! $secondArgValue instanceof ConstFetch) {
+            return null;
+        }
+
+        $constantFilterName = $secondArgValue->name->toString();
+
+        $valueType = $this->getType($firstArgValue);
+
+        if ($constantFilterName === 'FILTER_VALIDATE_INT' && $valueType->isInteger()->yes()) {
+            return $firstArgValue;
+        }
+
+        if ($constantFilterName === 'FILTER_VALIDATE_FLOAT' && $valueType->isFloat()->yes()) {
+            return $firstArgValue;
+        }
+
+        if (in_array($constantFilterName, ['FILTER_VALIDATE_BOOLEAN', 'FILTER_VALIDATE_BOOL']) && $valueType->isBoolean()->yes()) {
+            return $firstArgValue;
+        }
+
+        return null;
+    }
+}

src/Config/Level/DeadCodeLevel.php

@@ -33,6 +33,7 @@
 use Rector\DeadCode\Rector\For_\RemoveDeadIfForeachForRector;
 use Rector\DeadCode\Rector\For_\RemoveDeadLoopRector;
 use Rector\DeadCode\Rector\Foreach_\RemoveUnusedForeachKeyRector;
+use Rector\DeadCode\Rector\FuncCall\RemoveFilterVarOnExactTypeRector;
 use Rector\DeadCode\Rector\FunctionLike\RemoveDeadReturnRector;
 use Rector\DeadCode\Rector\If_\ReduceAlwaysFalseIfOrRector;
 use Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector;
@@ -85,6 +86,7 @@ final class DeadCodeLevel
         RemoveNullPropertyInitializationRector::class,
         RemoveUselessReturnExprInConstructRector::class,
         ReplaceBlockToItsStmtsRector::class,
+        RemoveFilterVarOnExactTypeRector::class,
 
         RemoveTypedPropertyDeadInstanceOfRector::class,
         TernaryToBooleanOrFalseToBooleanAndRector::class,