[CodeQuality] Skip no code parameter on custom Throwable instance on ThrowWithPreviousExceptionRector

Author: samsonasik

rules-tests/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector/Fixture/empty_brackets.php.inc

@@ -8,8 +8,8 @@ class EmptyBrackets
     {
         try {
             $someCode = 1;
-        } catch (Throwable $throwable) {
-            throw new AnotherException;
+        } catch (\Throwable $throwable) {
+            throw new \RuntimeException;
         }
     }
 }
@@ -26,8 +26,8 @@ class EmptyBrackets
     {
         try {
             $someCode = 1;
-        } catch (Throwable $throwable) {
-            throw new AnotherException($throwable->getMessage(), $throwable->getCode(), $throwable);
+        } catch (\Throwable $throwable) {
+            throw new \RuntimeException($throwable->getMessage(), $throwable->getCode(), $throwable);
         }
     }
 }

rules-tests/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector/Fixture/fixture.php.inc

@@ -8,8 +8,8 @@ class Fixture
     {
         try {
             $someCode = 1;
-        } catch (Throwable $throwable) {
-            throw new AnotherException('ups');
+        } catch (\Throwable $throwable) {
+            throw new \RuntimeException('ups');
         }
     }
 }
@@ -26,8 +26,8 @@ class Fixture
     {
         try {
             $someCode = 1;
-        } catch (Throwable $throwable) {
-            throw new AnotherException('ups', $throwable->getCode(), $throwable);
+        } catch (\Throwable $throwable) {
+            throw new \RuntimeException('ups', $throwable->getCode(), $throwable);
         }
     }
 }

rules-tests/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector/Fixture/named_argument.php.inc

@@ -9,7 +9,7 @@ class NamedArgument
 		try {
             $this->run();
         }catch(\Throwable $throwable) {
-            throw new LogicException('Some exception', previous: $throwable);
+            throw new \LogicException('Some exception', previous: $throwable);
         }
     }
 }
@@ -27,7 +27,7 @@ class NamedArgument
 		try {
             $this->run();
         }catch(\Throwable $throwable) {
-            throw new LogicException('Some exception', $throwable->getCode(), previous: $throwable);
+            throw new \LogicException('Some exception', $throwable->getCode(), previous: $throwable);
         }
     }
 }

rules-tests/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector/Fixture/named_argument_for_message.php.inc

@@ -9,7 +9,7 @@ class NamedArgumentForMessage
 		try {
             $this->run();
         }catch(\Throwable $throwable) {
-            throw new LogicException(message: 'Some exception');
+            throw new \LogicException(message: 'Some exception');
         }
     }
 }
@@ -27,7 +27,7 @@ class NamedArgumentForMessage
 		try {
             $this->run();
         }catch(\Throwable $throwable) {
-            throw new LogicException(message: 'Some exception', code: $throwable->getCode(), previous: $throwable);
+            throw new \LogicException(message: 'Some exception', code: $throwable->getCode(), previous: $throwable);
         }
     }
 }

rules-tests/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector/Fixture/skip_custom_exception_no_code_param.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Catch_\ThrowWithPreviousExceptionRector\Fixture;
+
+use stdClass;
+
+class Error extends \Exception
+{
+    public function __construct(
+        string $message = '',
+        $nodes = null,
+        ?stdClass $source = null,
+        ?array $positions = null,
+        ?array $path = null,
+        ?\Throwable $previous = null,
+        ?array $extensions = null,
+        ?array $unaliasedPath = null
+    ) {
+        parent::__construct($message, 0, $previous);
+    }
+}
+
+try {
+    throw new \InvalidArgumentException('foo');
+} catch (\InvalidArgumentException $e) {
+    throw new Error(message: 'Some error message', previous: $e);
+}

rules-tests/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector/Fixture/skip_custom_exception_param_order_flipped_no_namespace.php.inc

@@ -19,7 +19,7 @@ class HttpException extends \RuntimeException
 
 class BadGatewayHttpException extends HttpException
 {
-    public function __construct(string $message = '', ?Throwable $previous = null, array $headers = [], int $code = 0)
+    public function __construct(string $message = '', ?\Throwable $previous = null, array $headers = [], int $code = 0)
     {
         parent::__construct(Response::HTTP_BAD_GATEWAY, $message, $previous, $headers, $code);
     }

rules-tests/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector/Fixture/skip_filled_exception_with_different_location.php.inc

@@ -10,15 +10,15 @@ class SkipFilledExceptionWithDifferentLocation
     public function run()
     {
         try {
-        } catch (Throwable $throwable) {
+        } catch (\Throwable $throwable) {
             throw new BadRequestHttpException('message some', $throwable);
         }
     }
 }
 
 class BadRequestHttpException extends  Exception
 {
-    public function __construct(string $message = null, \Throwable $previous = null, int $code = 0, array $headers = [])
+    public function __construct(string $message = null, ?\Throwable $previous = null, int $code = 0, array $headers = [])
     {
         parent::__construct('message', 400, $previous);
     }

rules-tests/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector/Fixture/skip_missing_location.php.inc

@@ -10,7 +10,7 @@ class SkipMissingLocation
     public function run()
     {
         try {
-        } catch (Throwable $throwable) {
+        } catch (\Throwable $throwable) {
             throw new MissingPreviousException('message some');
         }
     }