handle FiberScope

Author: samsonasik

rules/CodeQuality/Rector/Empty_/SimplifyEmptyCheckOnEmptyArrayRector.php

@@ -21,6 +21,7 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
 use Rector\NodeAnalyzer\ExprAnalyzer;
+use Rector\NodeTypeResolver\PHPStan\Scope\ScopeTypeHelper;
 use Rector\Php\ReservedKeywordAnalyzer;
 use Rector\PhpParser\AstResolver;
 use Rector\PHPStan\ScopeFetcher;
@@ -106,7 +107,7 @@ private function isAllowedVariable(Variable $variable): bool
 
     private function isAllowedExpr(Expr $expr, Scope $scope): bool
     {
-        if (! $scope->getType($expr)->isArray()->yes()) {
+        if (! ScopeTypeHelper::getType($scope, $expr)->isArray()->yes()) {
             return false;
         }
 

rules/DeadCode/Rector/If_/RemoveAlwaysTrueIfConditionRector.php

@@ -23,6 +23,7 @@
 use Rector\DeadCode\NodeAnalyzer\SafeLeftTypeBooleanAndOrAnalyzer;
 use Rector\NodeAnalyzer\ExprAnalyzer;
 use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\NodeTypeResolver\PHPStan\Scope\ScopeTypeHelper;
 use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\PHPStan\ScopeFetcher;
 use Rector\Rector\AbstractRector;
@@ -120,7 +121,7 @@ public function refactor(Node $node): int|null|array|If_
         }
 
         $scope = ScopeFetcher::fetch($node);
-        $type = $scope->getNativeType($node->cond);
+        $type = ScopeTypeHelper::getNativeType($scope, $node->cond);
         if (! $type->isTrue()->yes()) {
             return null;
         }

rules/DeadCode/Rector/If_/RemoveUnusedNonEmptyArrayBeforeForeachRector.php

@@ -19,6 +19,7 @@
 use Rector\NodeAnalyzer\PropertyFetchAnalyzer;
 use Rector\NodeManipulator\IfManipulator;
 use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\NodeTypeResolver\PHPStan\Scope\ScopeTypeHelper;
 use Rector\Php\ReservedKeywordAnalyzer;
 use Rector\PhpParser\Enum\NodeGroup;
 use Rector\PHPStan\ScopeFetcher;
@@ -122,7 +123,7 @@ private function isUselessBeforeForeachCheck(If_ $if, Scope $scope): bool
         if (($ifCond instanceof Variable || $this->propertyFetchAnalyzer->isPropertyFetch($ifCond))
             && $this->nodeComparator->areNodesEqual($ifCond, $foreachExpr)
         ) {
-            $ifType = $scope->getNativeType($ifCond);
+            $ifType = ScopeTypeHelper::getNativeType($scope, $ifCond);
             return $ifType->isArray()
                 ->yes();
         }
@@ -192,7 +193,7 @@ private function refactorStmtsAware(Node $stmtsAware): ?Node
                 continue;
             }
 
-            $ifType = $scope->getNativeType($empty->expr);
+            $ifType = ScopeTypeHelper::getNativeType($scope, $empty->expr);
             if (! $ifType->isArray()->yes()) {
                 continue;
             }
@@ -238,7 +239,7 @@ private function shouldSkipForeachExpr(Expr $foreachExpr, Scope $scope): bool
                 return true;
             }
 
-            $ifType = $scope->getNativeType($foreachExpr);
+            $ifType = ScopeTypeHelper::getNativeType($scope, $foreachExpr);
             if (! $ifType->isArray()->yes()) {
                 return true;
             }

rules/DeadCode/UselessIfCondBeforeForeachDetector.php

@@ -14,6 +14,7 @@
 use PhpParser\Node\Stmt\Return_;
 use PHPStan\Analyser\Scope;
 use Rector\PhpParser\Comparing\NodeComparator;
+use Rector\NodeTypeResolver\PHPStan\Scope\ScopeTypeHelper;
 
 final readonly class UselessIfCondBeforeForeachDetector
 {
@@ -125,7 +126,7 @@ private function areCondExprAndForeachExprSame(Empty_ $empty, Expr $foreachExpr,
         }
 
         // is array though?
-        $arrayType = $scope->getType($empty->expr);
+        $arrayType = ScopeTypeHelper::getType($scope, $empty->expr);
         return $arrayType->isArray()
             ->yes();
     }

rules/Strict/Rector/Empty_/DisallowedEmptyRuleFixerRector.php

@@ -15,6 +15,7 @@
 use PHPStan\Analyser\Scope;
 use Rector\Contract\Rector\ConfigurableRectorInterface;
 use Rector\NodeAnalyzer\ExprAnalyzer;
+use Rector\NodeTypeResolver\PHPStan\Scope\ScopeTypeHelper;
 use Rector\PHPStan\ScopeFetcher;
 use Rector\Strict\NodeAnalyzer\UninitializedPropertyAnalyzer;
 use Rector\Strict\NodeFactory\ExactCompareFactory;
@@ -106,7 +107,7 @@ private function refactorBooleanNot(BooleanNot $booleanNot, Scope $scope): Expr|
             return null;
         }
 
-        $emptyExprType = $scope->getNativeType($empty->expr);
+        $emptyExprType = ScopeTypeHelper::getNativeType($scope, $empty->expr);
 
         $result = $this->exactCompareFactory->createNotIdenticalFalsyCompare(
             $emptyExprType,
@@ -131,7 +132,7 @@ private function refactorEmpty(Empty_ $empty, Scope $scope, bool $treatAsNonEmpt
             return null;
         }
 
-        $exprType = $scope->getNativeType($empty->expr);
+        $exprType = ScopeTypeHelper::getNativeType($scope, $empty->expr);
         $result = $this->exactCompareFactory->createIdenticalFalsyCompare($exprType, $empty->expr, $treatAsNonEmpty);
         if (! $result instanceof Expr) {
             return null;

src/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php

@@ -158,6 +158,10 @@ public function processNodes(
             &$nodeCallback,
             $filePath,
         ): void {
+            if ($mutatingScope instanceof \PHPStan\Analyser\Fiber\FiberScope) {
+                $mutatingScope = $mutatingScope->toMutatingScope();
+            }
+
             // the class reflection is resolved AFTER entering to class node
             // so we need to get it from the first after this one
             if ($node instanceof Class_ || $node instanceof Interface_ || $node instanceof Enum_) {