[CodeQuality] Skip bool equal float on UseIdenticalOverEqualWithSameTypeRector (#7412)

* [CodeQuality] Skip bool equal float on UseIdenticalOverEqualWithSameTypeRector

* Fix

* fix

Author: samsonasik

rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/skip_bool_equal_float.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector\Fixture;
+
+/**
+ * @see https://3v4l.org/I3GQS
+ */
+final class SkipBoolEqualFloat
+{
+    public function equal()
+    {
+        // maybe compare to numeric string
+        $value = rand(0, 1) ? 1.0 : null;
+
+        var_dump(true == $value);
+        var_dump($value == true);
+    }
+}

rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php

@@ -103,28 +103,33 @@ public function refactor(Node $node): ?Node
 
     private function shouldSkipCompareBoolToNumeric(Type $leftStaticType, Type $rightStaticType): bool
     {
-        // use ! ->no() as to verify both yes and maybe
         if ($leftStaticType instanceof BooleanType) {
-            if (! $rightStaticType->isNumericString()->no()) {
-                return true;
-            }
-
-            return ! $rightStaticType->isInteger()
-                ->no();
+            return $this->shouldSkipNumericType($rightStaticType);
         }
 
         if ($rightStaticType instanceof BooleanType) {
-            if (! $leftStaticType->isNumericString()->no()) {
-                return true;
-            }
-
-            return ! $leftStaticType->isInteger()
-                ->no();
+            return $this->shouldSkipNumericType($leftStaticType);
         }
 
         return false;
     }
 
+    private function shouldSkipNumericType(Type $type): bool
+    {
+        // use ! ->no() as to verify both yes and maybe
+        if (! $type->isNumericString()->no()) {
+            return true;
+        }
+
+        if (! $type->isInteger()
+            ->no()) {
+            return true;
+        }
+
+        return ! $type->isFloat()
+            ->no();
+    }
+
     private function processIdenticalOrNotIdentical(Equal|NotEqual $node): Identical|NotIdentical
     {
         if ($node instanceof Equal) {