skip bare spread arg as well

Author: TomasVotruba

rules-tests/TypeDeclaration/Rector/ClassMethod/ParamTypeByParentCallTypeRector/Fixture/skip_just_spreaded_arg.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ParamTypeByParentCallTypeRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\ClassMethod\ParamTypeByParentCallTypeRector\Source\ParentClassWithArraySpread;
+
+final class SkipJustSPreadedArg extends ParentClassWithArraySpread
+{
+    public function __construct($items)
+    {
+        parent::__construct(...$items);
+    }
+}

rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByParentCallTypeRector.php

@@ -5,7 +5,9 @@
 namespace Rector\TypeDeclaration\Rector\ClassMethod;
 
 use PhpParser\Node;
+use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\StaticCall;
+use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Reflection\ClassReflection;
@@ -108,6 +110,10 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            if ($this->isParamUsedInSpreadArg($node, $param)) {
+                continue;
+            }
+
             $parentParam = $this->callerParamMatcher->matchParentParam($parentStaticCall, $param, $scope);
             if (! $parentParam instanceof Param) {
                 continue;
@@ -172,4 +178,23 @@ private function shouldSkip(ClassMethod $classMethod): bool
 
         return ! $classReflection->isClass();
     }
+
+    private function isParamUsedInSpreadArg(ClassMethod $classMethod, Param $param): bool
+    {
+        /** @var Arg[] $args */
+        $args = $this->betterNodeFinder->findInstancesOfScoped((array) $classMethod->stmts, Arg::class);
+
+        $paramName = $this->getName($param);
+        foreach ($args as $arg) {
+            if (! $arg->unpack) {
+                continue;
+            }
+
+            if ($arg->value instanceof Variable && $this->isName($arg->value, $paramName)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
 }