simpler docblock

Author: TomasVotruba

rules/DeadCode/Rector/Expression/RemoveDeadStmtRector.php

@@ -4,6 +4,7 @@
 
 namespace Rector\DeadCode\Rector\Expression;
 
+use PhpParser\Comment\Doc;
 use PhpParser\Node;
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Expr\StaticPropertyFetch;
@@ -108,7 +109,7 @@ private function hasGetMagic(Expression $expression): bool
      */
     private function removeNodeAndKeepComments(Expression $expression): int|Node
     {
-        if ($expression->getComments() !== []) {
+        if ($expression->getDocComment() instanceof Doc) {
             $nop = new Nop();
             $nop->setDocComment($expression->getDocComment());
 

rules/Php74/Rector/Closure/ClosureToArrowFunctionRector.php

@@ -89,7 +89,7 @@ public function refactor(Node $node): ?Node
         $comments = $node->stmts[0]->getAttribute(AttributeKey::COMMENTS) ?? [];
         if ($comments !== []) {
             $this->mirrorComments($arrowFunction->expr, $node->stmts[0]);
-            $arrowFunction->setAttribute(AttributeKey::COMMENT_CLOSURE_RETURN_MIRRORED, true);
+            $arrowFunction->setAttribute(AttributeKey::COMMENTS, true);
         }
 
         return $arrowFunction;

src/NodeTypeResolver/Node/AttributeKey.php

@@ -92,11 +92,6 @@ final class AttributeKey
      */
     public const WRAPPED_IN_PARENTHESES = 'wrapped_in_parentheses';
 
-    /**
-     * @var string
-     */
-    public const COMMENT_CLOSURE_RETURN_MIRRORED = 'comment_closure_return_mirrored';
-
     /**
      * To pass PHP 8.0 attribute FQN names
      * @var string

src/PhpParser/Printer/BetterStandardPrinter.php

@@ -161,7 +161,7 @@ protected function p(
 
     protected function pExpr_ArrowFunction(ArrowFunction $arrowFunction, int $precedence, int $lhsPrecedence): string
     {
-        if (! $arrowFunction->hasAttribute(AttributeKey::COMMENT_CLOSURE_RETURN_MIRRORED)) {
+        if (! $arrowFunction->hasAttribute(AttributeKey::COMMENTS)) {
             return parent::pExpr_ArrowFunction($arrowFunction, $precedence, $lhsPrecedence);
         }