fixup! [perf] [experiment] preload all node classes once at start

Author: TomasVotruba

scripts/src/Finder/NodeClassFinder.php

@@ -30,11 +30,11 @@ public static function find(): array
 
         $instantiableNodeClasses = array_filter($nodeClasses, function (string $nodeClass): bool {
             $nodeClassReflection = new ReflectionClass($nodeClass);
-           if ($nodeClassReflection->isAbstract()) {
-               return false;
-           }
+            if ($nodeClassReflection->isAbstract()) {
+                return false;
+            }
 
-           return ! $nodeClassReflection->isInterface();
+            return ! $nodeClassReflection->isInterface();
         });
 
         return $instantiableNodeClasses;

src/PhpParser/NodeTraverser/RectorNodeTraverser.php

@@ -68,28 +68,28 @@ public function getVisitorsForNode(Node $node): array
         Assert::true($this->areNodeVisitorsPrepared);
 
         return $this->visitorsPerNodeClass[$node::class] ?? [];
-//
-//        $nodeClass = $node::class;
-//
-//        static $isACheckCounter = 0;
-//
-//        if (! isset($this->visitorsPerNodeClass[$nodeClass])) {
-//            $this->visitorsPerNodeClass[$nodeClass] = [];
-//            /** @var RectorInterface $visitor */
-//            foreach ($this->visitors as $visitor) {
-//                foreach ($visitor->getNodeTypes() as $nodeType) {
-//                    if (is_a($nodeClass, $nodeType, true)) {
-//                        ++$isACheckCounter;
-//
-//                        $this->visitorsPerNodeClass[$nodeClass][] = $visitor;
-//                        continue 2;
-//                    }
-//                }
-//            }
-//
-//            dump($isACheckCounter);
-//        }
-//        return $this->visitorsPerNodeClass[$nodeClass];
+        //
+        //        $nodeClass = $node::class;
+        //
+        //        static $isACheckCounter = 0;
+        //
+        //        if (! isset($this->visitorsPerNodeClass[$nodeClass])) {
+        //            $this->visitorsPerNodeClass[$nodeClass] = [];
+        //            /** @var RectorInterface $visitor */
+        //            foreach ($this->visitors as $visitor) {
+        //                foreach ($visitor->getNodeTypes() as $nodeType) {
+        //                    if (is_a($nodeClass, $nodeType, true)) {
+        //                        ++$isACheckCounter;
+        //
+        //                        $this->visitorsPerNodeClass[$nodeClass][] = $visitor;
+        //                        continue 2;
+        //                    }
+        //                }
+        //            }
+        //
+        //            dump($isACheckCounter);
+        //        }
+        //        return $this->visitorsPerNodeClass[$nodeClass];
     }
 
     /**
@@ -117,7 +117,7 @@ private function prepareNodeVisitors(): void
             foreach ($this->visitors as $visitor) {
                 foreach ($visitor->getNodeTypes() as $matchingNodeType) {
                     if (is_a($nodeClass, $matchingNodeType, true)) {
-                        $this->visitorsPerNodeClass[$nodeClass][]  = $visitor;
+                        $this->visitorsPerNodeClass[$nodeClass][] = $visitor;
 
                         ++$counter;
                     }