include override in cild class

Author: TomasVotruba

rules-tests/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector/Fixture/allow_override.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ChildClassNotWithConstant;
+
+final class AllowOverride
+{
+    public function run(ChildClassNotWithConstant $classWithConstants)
+    {
+        return $classWithConstants::ORIGINAL_VALUE;
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ChildClassNotWithConstant;
+
+final class AllowOverride
+{
+    public function run(ChildClassNotWithConstant $classWithConstants)
+    {
+        return \Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ChildClassNotWithConstant::ORIGINAL_VALUE;
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector/Fixture/parent_hop_fetch.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ChildClassNotWithConstant;
+
+final class ParentHopFetch
+{
+    public function run(ChildClassNotWithConstant $classWithConstants)
+    {
+        return $classWithConstants::NAME;
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ChildClassNotWithConstant;
+
+final class ParentHopFetch
+{
+    public function run(ChildClassNotWithConstant $classWithConstants)
+    {
+        return \Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ChildClassNotWithConstant::NAME;
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector/Fixture/skip_unknown_class.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source\ChildClassNotWithConstant;
+
+final class SkipUnknownClass
+{
+    public function run($classWithConstants)
+    {
+        return $classWithConstants::ORIGINAL_VALUE;
+    }
+}

rules-tests/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector/Source/ChildClassNotWithConstant.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source;
+
+final class ChildClassNotWithConstant extends ClassWithConstants
+{
+    public const ORIGINAL_VALUE = 456;
+}

rules-tests/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector/Source/ClassWithConstants.php

@@ -1,8 +1,12 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\VariableConstFetchToClassConstFetchRector\Source;
 
-final class ClassWithConstants
+class ClassWithConstants
 {
     public const NAME = 'SomeName';
+
+    public const ORIGINAL_VALUE = 123;
 }

rules/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector.php

@@ -4,6 +4,8 @@
 
 namespace Rector\CodeQuality\Rector\ClassConstFetch;
 
+use PhpParser\Node\Identifier;
+use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\ClassConstFetch;
@@ -64,11 +66,14 @@ public function refactor(Node $node): ?ClassConstFetch
             return null;
         }
 
-        if (! $node->name instanceof Node\Identifier) {
+        if (! $node->name instanceof Identifier) {
             return null;
         }
 
         $constantName = $this->getName($node->name);
+        if (! is_string($constantName)) {
+            return null;
+        }
 
         $classObjectType = $this->getType($node->class);
         if (! $classObjectType instanceof ObjectType) {
@@ -79,7 +84,7 @@ public function refactor(Node $node): ?ClassConstFetch
             return null;
         }
 
-        $node->class = new Node\Name\FullyQualified($classObjectType->getClassName());
+        $node->class = new FullyQualified($classObjectType->getClassName());
 
         return $node;
     }