add tests

Author: TomasVotruba

.github/workflows/code_analysis.yaml

@@ -21,9 +21,9 @@ jobs:
                         name: 'Run with Space in Directory'
                         run: bin/rector process tests-paths/path/with\ space/SomeFile.php --clear-cache
 
-#                    -
-#                        name: 'Preload php-parser Order'
-#                        run: php preload.php
+                    -
+                        name: 'Preload php-parser Order'
+                        run: php preload.php
 
                     -
                         name: 'PHPStan'

composer.json

@@ -81,6 +81,7 @@
                 "rules-tests",
                 "tests"
             ],
+            "Rector\\Utils\\Tests\\": "utils-tests",
             "E2e\\Parallel\\Reflection\\Resolver\\": [
                 "e2e/parallel-reflection-resolver/src/",
                 "e2e/no-parallel-reflection-resolver/src"

phpstan.neon

@@ -360,3 +360,4 @@ parameters:
         -
             message: '#Method Rector\\Utils\\Rector\\MakeUseOfContaintsStmtsRector\:\:refactor\(\) should return 4\|PhpParser\\Node\\Expr\\BinaryOp\\Identical\|PhpParser\\Node\\Expr\\MethodCall\|null but returns int\|null#'
             path: utils/Rector/MakeUseOfContaintsStmtsRector.php
+        - message: '#Method Rector\\Utils\\Rector\\MakeUseOfContainsStmtsRector\:\:refactor\(\) should return 4\|PhpParser\\Node\\Expr\\BinaryOp\\Identical\|PhpParser\\Node\\Expr\\MethodCall\|null but returns int\|null#'

rector.php

@@ -6,7 +6,7 @@
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\ConstFetch\RemovePhpVersionIdCheckRector;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
-use Rector\Utils\Rector\MakeUseOfContaintsStmtsRector;
+use Rector\Utils\Rector\MakeUseOfContainsStmtsRector;
 
 return RectorConfig::configure()
     ->withPreparedSets(
@@ -36,7 +36,7 @@
         __DIR__ . '/config',
         __DIR__ . '/build/build-preload.php',
     ])
-    ->withRules([MakeUseOfContaintsStmtsRector::class])
+    ->withRules([MakeUseOfContainsStmtsRector::class])
     ->withRootFiles()
     ->withImportNames(removeUnusedImports: true)
     ->withSkip([

utils-tests/Rector/MakeUseOfContainsStmtsRector/Fixture/contains_stmts_contract.php.inc

@@ -0,0 +1,39 @@
+<?php
+
+namespace Rector\Utils\Tests\Rector\MakeUseOfContainsStmtsRector\Fixture;
+
+use PhpParser\Node\ContainsStmts;
+
+final class ContaintsStmtsContract
+{
+    public function process(ContainsStmts $containsStmts): bool
+    {
+        if ($containsStmts->stmts === null) {
+            return false;
+        }
+
+        return true;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Utils\Tests\Rector\MakeUseOfContainsStmtsRector\Fixture;
+
+use PhpParser\Node\ContainsStmts;
+
+final class ContaintsStmtsContract
+{
+    public function process(ContainsStmts $containsStmts): bool
+    {
+        if ($containsStmts->getStmts() === []) {
+            return false;
+        }
+
+        return true;
+    }
+}
+
+?>

utils-tests/Rector/MakeUseOfContainsStmtsRector/Fixture/skip_child_of_contract.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Utils\Tests\Rector\MakeUseOfContainsStmtsRector\Fixture;
+
+use PhpParser\Node\Stmt\ClassMethod;
+
+final class SkipChildOfContract
+{
+    public function process(ClassMethod $classMethod): void
+    {
+        $stmts = $classMethod->stmts;
+    }
+}

utils-tests/Rector/MakeUseOfContainsStmtsRector/Fixture/skip_class.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Utils\Tests\Rector\MakeUseOfContainsStmtsRector\Fixture;
+
+use PhpParser\Node\Stmt\Class_;
+
+final class SkipClass
+{
+    public function process(Class_ $class): void
+    {
+        $stmts = $class->stmts;
+    }
+}

utils-tests/Rector/MakeUseOfContainsStmtsRector/MakeUseOfContainsStmtsRectorTest.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Utils\Tests\Rector\MakeUseOfContainsStmtsRector;
+
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class MakeUseOfContainsStmtsRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): \Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

utils-tests/Rector/MakeUseOfContainsStmtsRector/config/configured_rule.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Utils\Rector\MakeUseOfContainsStmtsRector;
+
+return RectorConfig::configure()
+    ->withRules([
+        MakeUseOfContainsStmtsRector::class,
+    ]);

…Rector/MakeUseOfContaintsStmtsRector.php …/Rector/MakeUseOfContainsStmtsRector.phputils/Rector/MakeUseOfContaintsStmtsRector.php renamed to utils/Rector/MakeUseOfContainsStmtsRector.php utils/Rector/MakeUseOfContaintsStmtsRector.php renamed to utils/Rector/MakeUseOfContainsStmtsRector.php

@@ -18,12 +18,16 @@
 use PhpParser\Node\Stmt\Foreach_;
 use PhpParser\Node\Stmt\Function_;
 use PhpParser\NodeVisitor;
+use PHPStan\Reflection\ClassReflection;
 use PHPStan\Type\ObjectType;
 use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
-final class MakeUseOfContaintsStmtsRector extends AbstractRector
+/**
+ * @see \Rector\Utils\Tests\Rector\MakeUseOfContainsStmtsRector\MakeUseOfContainsStmtsRectorTest
+ */
+final class MakeUseOfContainsStmtsRector extends AbstractRector
 {
     public function __construct(
         private readonly ValueResolver $valueResolver
@@ -87,6 +91,16 @@ public function refactor(Node $node): MethodCall|Identical|null|int
             return null;
         }
 
+        $callerType = $this->getType($node->var);
+        if ($callerType instanceof ObjectType) {
+            /** @var ClassReflection $callerClassReflection */
+            $callerClassReflection = $callerType->getClassReflection();
+            if (! $callerClassReflection->isInterface()) {
+                // we have to match interface exactly
+                return null;
+            }
+        }
+
         return new MethodCall($node->var, 'getStmts');
     }