[CodeQuality] Handle property fetch and common nodes crash on InlineArrayReturnAssignRector

samsonasik · samsonasik · commit 4c6ed0dec9d6 · 2025-10-07T03:49:03.000+07:00
diff --git a/src/PhpParser/Node/NodeFactory.php b/src/PhpParser/Node/NodeFactory.php
@@ -426,12 +426,8 @@ private function createArrayItem(mixed $item, string | int | null $key = null):
             return new ArrayItem($item);
         }
 
-        $nodeClass = $item;
-        throw new NotImplementedYetException(sprintf(
-            'Not implemented yet. Go to "%s()" and add check for "%s" node.',
-            __METHOD__,
-            (string) $nodeClass
-        ));
+        $itemValue = BuilderHelpers::normalizeValue($item);
+        return new ArrayItem($itemValue);
     }
 
     private function decorateArrayItemWithKey(int | string | null $key, ArrayItem $arrayItem): void

Original file line number	Diff line number	Diff line change
`@@ -426,12 +426,8 @@ private function createArrayItem(mixed $item, string \| int \| null $key = null):`
`426`	`426`	`return new ArrayItem($item);`
`427`	`427`	`}`
`428`	`428`
`429`		`- $nodeClass = $item;`
`430`		`- throw new NotImplementedYetException(sprintf(`
`431`		`- 'Not implemented yet. Go to "%s()" and add check for "%s" node.',`
`432`		`- __METHOD__,`
`433`		`- (string) $nodeClass`
`434`		`- ));`
	`429`	`+ $itemValue = BuilderHelpers::normalizeValue($item);`
	`430`	`+ return new ArrayItem($itemValue);`
`435`	`431`	`}`
`436`	`432`
`437`	`433`	`private function decorateArrayItemWithKey(int \| string \| null $key, ArrayItem $arrayItem): void`